Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: tests/language/vm/causal_async_exception_stack_test.dart

Issue 2690683002: Improvements to causal async stack traces (Closed)
Patch Set: rmacnak review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/vm/causal_async_exception_stack_test.dart
diff --git a/tests/language/vm/causal_async_exception_stack_test.dart b/tests/language/vm/causal_async_exception_stack_test.dart
index 5e8eee0061fb72b969dfb62e854af83bdae0f8a2..98d5544cf8bbbb0feb314682d27a39e1bfb1c67d 100644
--- a/tests/language/vm/causal_async_exception_stack_test.dart
+++ b/tests/language/vm/causal_async_exception_stack_test.dart
@@ -28,14 +28,35 @@ main() async {
await foo();
} catch (e, st) {
expect(st.toString(), stringContainsInOrder([
- 'thrower.<thrower_async_body>',
- '<asynchronous suspension>',
'thrower',
- 'generator.<generator_async_gen_body>',
'<asynchronous suspension>',
'generator',
- 'foo.<foo_async_body>',
'<asynchronous suspension>',
+ 'foo',
+ '<asynchronous suspension>',
+ 'main',
]));
siva 2017/02/11 00:24:33 might be interesting to add try { a
Cutch 2017/02/11 01:14:28 Done.
}
+
+ inner() async {
+ deep() async {
+ await thrower();
+ }
+ await deep();
+ }
+
+ try {
+ await inner();
+ } catch (e, st) {
+ expect(st.toString(), stringContainsInOrder([
+ 'thrower',
+ '<asynchronous suspension>',
+ 'main.inner.deep',
+ '<asynchronous suspension>',
+ 'main.inner',
+ '<asynchronous suspension>',
+ 'main',
+ '<asynchronous suspension>',
+ ]));
+ }
}
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698