Set os_error to net::ERR_ABORTED instead of 0 or net::ERR_FAILED when...

Set os_error to net::ERR_ABORTED instead of 0 or net::ERR_FAILED when
we set the status of a URLRequestStatus to URLRequestStatus::CANCELED.

R=eroman
BUG=24674
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29367

[wtc, 2009-10-13 17:16:10]

eroman: please review this CL.

abarth,jcampan: are you familiar with the
SecurityFilterPeer::CreateSecurityFilterPeerForDeniedRequest
call in ResourceDispatcher::OnRequestComplete?  This CL
changes the os_error associated with URLRequestStatus::CANCELED
in a few places where we were setting os_error to 0 (which
means net::OK) or net::ERR_FAILED before/  This CL will
prevent a new SecurityFilterPeer from being created for
those canceled URLRequests.

[eroman, 2009-10-13 19:15:38]

LGTM

http://codereview.chromium.org/269064/diff/3001/3003
File chrome/browser/views/about_network_dialog.cc (right):

http://codereview.chromium.org/269064/diff/3001/3003#newcode229
Line 229: DCHECK_EQ(status.status(), URLRequestStatus::FAILED);
this dcheck seems awkward to me.

instead you could turn this into a switch where the "default:" case is omitted
(this should cause the compiler to emit a warning/error if a new value gets
added to the enum).

[wtc, 2009-10-16 02:39:28]

I rewrote the if statement as a switch statement as
you suggested.  But I don't know how to test my changes to
about_network_dialog.cc.

[wtc, 2009-10-16 02:44:27]

http://codereview.chromium.org/269064/diff/5001/6002
File chrome/browser/views/about_network_dialog.cc (right):

http://codereview.chromium.org/269064/diff/5001/6002#newcode238
Line 238: swprintf(buf, arraysize(buf), L"Failed with %d: ", status.os_error());
The "Failed with %d: " string is the only string that doesn't
begin with "- ".  This is why I'd like to test
about_network_dialog.c to see what it looks like.

[eroman, 2009-10-16 03:12:14]

lgtm

http://codereview.chromium.org/269064/diff/5001/6002
File chrome/browser/views/about_network_dialog.cc (right):

http://codereview.chromium.org/269064/diff/5001/6002#newcode238
Line 238: swprintf(buf, arraysize(buf), L"Failed with %d: ", status.os_error());
On 2009/10/16 02:44:27, wtc wrote:
> The "Failed with %d: " string is the only string that doesn't
> begin with "- ".  This is why I'd like to test
> about_network_dialog.c to see what it looks like.

You can test about:network on windows.
(It just doesn't work on mac/linux, or on official builds).

Also a nit, can you use StringPrintf() here instead? (string_util.h)

http://codereview.chromium.org/269064/diff/5001/6002#newcode244
Line 244: text.assign(L"- Unknown status: ");
(Note that when I suggested using a switch it was in order to *omit* the default
case so rather than getting a runtime error you get a compile error)

[wtc, 2009-10-17 01:37:04]

I found that about:network shows the URLRequests that
failed as "Canceled".  (I tried http://no.such.test/
and http://mycomputer:8080/.)  Very strange!
Therefore I removed about_network_dialog.cc from the CL
before I checked it in.