Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2690603003: Timeline: streamline flame chart views update logic (Closed)
Patch Set: moar fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Timeline.TimelineDetailsView = class extends UI.VBox { 8 Timeline.TimelineDetailsView = class extends UI.VBox {
9 /** 9 /**
10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters 10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 this._tabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._ta bSelected, this); 49 this._tabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._ta bSelected, this);
50 } 50 }
51 51
52 /** 52 /**
53 * @param {?Timeline.PerformanceModel} model 53 * @param {?Timeline.PerformanceModel} model
54 */ 54 */
55 setModel(model) { 55 setModel(model) {
56 this._model = model; 56 this._model = model;
57 this._tabbedPane.closeTabs( 57 this._tabbedPane.closeTabs(
58 [Timeline.TimelineDetailsView.Tab.PaintProfiler, Timeline.TimelineDetail sView.Tab.LayerViewer], false); 58 [Timeline.TimelineDetailsView.Tab.PaintProfiler, Timeline.TimelineDetail sView.Tab.LayerViewer], false);
59 for (var view of this._rangeDetailViews.values())
60 view.setModel(model);
59 this._lazyPaintProfilerView = null; 61 this._lazyPaintProfilerView = null;
60 this._lazyLayersView = null; 62 this._lazyLayersView = null;
61 } 63 }
62 64
63 /** 65 /**
64 * @param {!Node} node 66 * @param {!Node} node
65 */ 67 */
66 _setContent(node) { 68 _setContent(node) {
67 const allTabs = this._tabbedPane.otherTabs(Timeline.TimelineDetailsView.Tab. Details); 69 const allTabs = this._tabbedPane.otherTabs(Timeline.TimelineDetailsView.Tab. Details);
68 for (var i = 0; i < allTabs.length; ++i) { 70 for (var i = 0; i < allTabs.length; ++i) {
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 * @enum {string} 236 * @enum {string}
235 */ 237 */
236 Timeline.TimelineDetailsView.Tab = { 238 Timeline.TimelineDetailsView.Tab = {
237 Details: 'Details', 239 Details: 'Details',
238 Events: 'Events', 240 Events: 'Events',
239 CallTree: 'CallTree', 241 CallTree: 'CallTree',
240 BottomUp: 'BottomUp', 242 BottomUp: 'BottomUp',
241 PaintProfiler: 'PaintProfiler', 243 PaintProfiler: 'PaintProfiler',
242 LayerViewer: 'LayerViewer' 244 LayerViewer: 'LayerViewer'
243 }; 245 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698