Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 26906006: Move DOMSecurityPolicy and DOMTimer to frame/ (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, mkwst+watchlist_chromium.org, Inactive
Visibility:
Public.

Description

Move DOMSecurityPolicy and DOMTimer to frame/ I also moved WorkerNavigator to workers/ Almost all of the frame-level concepts are now gone from page/ However the dependencies between page/ and the rest of core/ are still all sorts of spaghetti. The next step for OOPI will be to remove includes of the page/ directory from the rest of the core/ blink code. This will require adding abstractions to the various page-level concepts which can be accessed off of Client objects held on Frame. Just getting started. BUG=305811 TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -999 lines) Patch
Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/bindings/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/core.gypi View 15 chunks +45 lines, -45 lines 0 comments Download
Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/ScriptExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/ScriptExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/events/DocumentEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMSecurityPolicy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/frame/DOMSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMTimer.h View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMWindowTimers.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/SecurityPolicy.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/frame/SuspendableTimer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/frame/SuspendableTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/DOMSecurityPolicy.h View 1 chunk +0 lines, -72 lines 0 comments Download
Source/core/page/DOMSecurityPolicy.cpp View 1 chunk +0 lines, -176 lines 0 comments Download
Source/core/page/DOMTimer.h View 1 chunk +0 lines, -82 lines 0 comments Download
Source/core/page/DOMTimer.cpp View 1 chunk +0 lines, -201 lines 0 comments Download
Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/ResourceTimingInfo.h View 1 chunk +0 lines, -81 lines 0 comments Download
Source/core/page/SecurityPolicy.idl View 1 chunk +0 lines, -45 lines 0 comments Download
Source/core/page/SuspendableTimer.h View 1 chunk +0 lines, -61 lines 0 comments Download
Source/core/page/SuspendableTimer.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
Source/core/page/WorkerNavigator.h View 1 chunk +0 lines, -53 lines 0 comments Download
Source/core/page/WorkerNavigator.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
Source/core/page/WorkerNavigator.idl View 1 chunk +0 lines, -35 lines 0 comments Download
Source/core/timing/Performance.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/timing/PerformanceResourceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/timing/ResourceTimingInfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/workers/WorkerNavigator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/workers/WorkerNavigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/workers/WorkerNavigator.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/quota/WorkerNavigatorStorageQuota.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eseidel
7 years, 2 months ago (2013-10-11 03:31:48 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r159416 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698