Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2690583003: Fix for https://github.com/dart-lang/sdk/issues/28727 (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for https://github.com/dart-lang/sdk/issues/28727 Use jsAst.Name uniformly in constructor parameters to prevent type argument being renamed into a conflict. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6af28fcb70010f5804410890e5ac2b29858808a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 10 months ago (2017-02-10 20:38:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-10 21:07:11 UTC) #3
sra1
3 years, 10 months ago (2017-02-10 21:19:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6af28fcb70010f5804410890e5ac2b29858808a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698