Make cc/paint have concrete types

third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
     return;
   GrContext* grContext = SharedGpuContext::gr();
   m_contextId = SharedGpuContext::contextId();
   CHECK(grContext);
 
   SkAlphaType alphaType =
       (Opaque == opacityMode) ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
   SkImageInfo info = SkImageInfo::Make(size.width(), size.height(), colorType,
                                        alphaType, colorSpace);
   SkSurfaceProps disableLCDProps(0, kUnknown_SkPixelGeometry);
-  m_surface = PaintSurface::MakeRenderTarget(
+  m_surface = SkSurface::MakeRenderTarget(
       grContext, SkBudgeted::kYes, info, 0 /* sampleCount */,
       Opaque == opacityMode ? nullptr : &disableLCDProps);
-  if (!m_surface)
+  if (!m_surface || !m_surface->getCanvas())

[danakj, 2017/03/02 19:44:40]

I don't see how m_surface can return a null canvas
https://cs.chromium.org/chromium/src/third_party/skia/src/image/SkSurface.cpp...

[enne (OOO), 2017/03/02 23:59:44]

Good catch.  Removed this.

     return;
+  m_canvas = WTF::wrapUnique(new PaintCanvas(m_surface->getCanvas()));
   clear();
 
   // Always save an initial frame, to support resetting the top level matrix
   // and clip.
-  m_surface->getCanvas()->save();
+  m_canvas->save();
 }
 
 bool AcceleratedImageBufferSurface::isValid() const {
   return m_surface && SharedGpuContext::isValid() &&
          m_contextId == SharedGpuContext::contextId();
 }
 
 sk_sp<SkImage> AcceleratedImageBufferSurface::newImageSnapshot(AccelerationHint,
                                                                SnapshotReason) {
   return m_surface->makeImageSnapshot();
 }
 
 GLuint AcceleratedImageBufferSurface::getBackingTextureHandleForOverwrite() {
   if (!m_surface)
     return 0;
   return skia::GrBackendObjectToGrGLTextureInfo(
              m_surface->getTextureHandle(
-                 PaintSurface::kDiscardWrite_TextureHandleAccess))
+                 SkSurface::kDiscardWrite_TextureHandleAccess))
       ->fID;
 }
 
 }  // namespace blink