Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5693)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2690573002: MacViews: Handle three-finger swipe gestures for navigation. (Closed)
Patch Set: Address CL isues. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index f4dbf87a9b3440d7ce19808cf32bf6b2c92f3fe7..67a2a5e850362c7779d2535c19715b22bac7ff2f 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1938,6 +1938,29 @@ void BrowserView::Layout() {
IsToolbarVisible() ? FocusBehavior::ALWAYS : FocusBehavior::NEVER);
}
+void BrowserView::OnGestureEvent(ui::GestureEvent* event) {
+#if defined(OS_MACOSX)
+ auto get_gesture_command = [](ui::GestureEvent* event) {
tapted 2017/02/15 22:25:52 Inferring the return type of a lambda is a C++14 f
+ if (event->details().type() == ui::ET_GESTURE_SWIPE) {
+ if (event->details().swipe_left())
+ return base::Optional<int>(IDC_BACK);
+ else if (event->details().swipe_right())
+ return base::Optional<int>(IDC_FORWARD);
+ }
+ return base::Optional<int>();
+ };
+
+ auto command = get_gesture_command(event);
+ if (command.has_value() && chrome::IsCommandEnabled(browser(), *command)) {
+ chrome::ExecuteCommandWithDisposition(
+ browser(), *command, ui::DispositionFromEventFlags(event->flags()));
+ return;
+ }
+#endif // OS_MACOSX
+
+ ClientView::OnGestureEvent(event);
+}
+
void BrowserView::ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) {
if (!initialized_ && details.is_add && details.child == this && GetWidget()) {

Powered by Google App Engine
This is Rietveld 408576698