Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: docs/testing/web_platform_tests.md

Issue 2690553003: Update and slighly expand WPT docs (Closed)
Patch Set: Fix nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Web Platform Tests 1 # Web Platform Tests
2 2
3 The Web Platform Tests project provides a large number of conformance tests for 3 Interoperability between browsers is
4 different aspects of the Web Platform. Currently the tests are hosted on GitHub. 4 [critical](https://www.chromium.org/blink/platform-predictability) to
5 There are two main repositories, one for the CSS Working Group (aka csswg-test), 5 Chromium's mission of improving the web. We believe that leveraging and
6 and one for pretty much everything else (aka web-platform-tests). 6 contributing to a shared test suite is one of the most important tools in
7 7 achieving interoperability between browsers. The [web-platform-tests
8 There is a plan to merge csswg-test into web-platform-tests, so later, there 8 repository](https://github.com/w3c/web-platform-tests) is the primary shared
9 will be only one repository. 9 test suite where all browser engines are collaborating. There's also a
10 [csswg-test repository](https://github.com/w3c/csswg-test) for CSS tests, but
11 that will [soon be merged into
12 web-platform-tests](https://github.com/w3c/csswg-test/issues/1102).
10 13
11 [TOC] 14 [TOC]
12 15
13 ## Import 16 ## Import
14 17
15 Chromium has mirrors 18 Chromium has mirrors
16 ([web-platform-tests](https://chromium.googlesource.com/external/w3c/web-platfor m-tests/), 19 ([web-platform-tests](https://chromium.googlesource.com/external/w3c/web-platfor m-tests/),
17 [csswg-test](https://chromium.googlesource.com/external/w3c/csswg-test/)) of the 20 [csswg-test](https://chromium.googlesource.com/external/w3c/csswg-test/)) of the
18 GitHub repos, and periodically imports a subset of the tests so that they are 21 GitHub repos, and periodically imports a subset of the tests so that they are
19 run as part of the regular Blink layout test testing process. 22 run as part of the regular Blink layout test testing process.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 it, and on the next auto-import, the new tests should be imported. If you want 66 it, and on the next auto-import, the new tests should be imported. If you want
64 to import immediately, you can also run `wpt-import --allow-local-commits`. 67 to import immediately, you can also run `wpt-import --allow-local-commits`.
65 68
66 ## Contributing tests back to the Web Platform Tests project. 69 ## Contributing tests back to the Web Platform Tests project.
67 70
68 If you need to make changes to Web Platform Tests, just commit your changes 71 If you need to make changes to Web Platform Tests, just commit your changes
69 directly to 72 directly to
70 [LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) 73 [LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt)
71 and the changes will be automatically upstreamed within 24 hours. 74 and the changes will be automatically upstreamed within 24 hours.
72 75
76 Note that tests in Web Platform Tests are expected to match behavior defined by
77 the relevant WHATWG or W3C specification, not simply Blink's behavior. If in
78 doubt, please request code review from someone with expertise in the relevant
79 specification text.
80
73 Note: if you're adding a new test in `external/wpt`, you'll need to re-generate 81 Note: if you're adding a new test in `external/wpt`, you'll need to re-generate
74 MANIFEST.json manually until [CL 2644783003](https://crrev.com/2644783003) is 82 MANIFEST.json manually until [CL 2644783003](https://crrev.com/2644783003) is
75 landed. The command to do so is: 83 landed. The command to do so is:
76 84
77 ```bash 85 ```bash
78 Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work \ 86 Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work \
79 --tests-root=LayoutTests/external/wpt 87 --tests-root=LayoutTests/external/wpt
80 ``` 88 ```
81 89
82 ### Will the exported commits be linked to my GitHub profile? 90 ### Will the exported commits be linked to my GitHub profile?
83 91
84 The email you commit with in Chromium will be the author of the commit on 92 The email you commit with in Chromium will be the author of the commit on
85 GitHub. You can [add it as a secondary address on your GitHub 93 GitHub. You can [add it as a secondary address on your GitHub
86 account](https://help.github.com/articles/adding-an-email-address-to-your-github -account/) 94 account](https://help.github.com/articles/adding-an-email-address-to-your-github -account/)
87 to link your exported commits to your GitHub profile. 95 to link your exported commits to your GitHub profile.
88 96
89 ### What if there are conflicts? 97 ### What if there are conflicts?
90 98
91 This cannot be avoided entirely as the two repositories are independent, but 99 This cannot be avoided entirely as the two repositories are independent, but
92 should be rare with frequent imports and exports. When it does happen, manual 100 should be rare with frequent imports and exports. When it does happen, manual
93 intervention will be needed and in non-trivial cases you may be asked to help 101 intervention will be needed and in non-trivial cases you may be asked to help
94 resolve the conflict. 102 resolve the conflict.
95 103
96 ### Direct pull requests 104 ### Direct pull requests
97 105
98 It's still possible to make direct pull requests to web-platform-tests. The 106 It's still possible to make direct pull requests to web-platform-tests. The
99 processes for getting new tests committed the W3C repos are at 107 processes for getting new tests committed the W3C repos are at
100 http://testthewebforward.org/docs/. Some specifics are at 108 http://testthewebforward.org/docs/. Some specifics are at
101 http://testthewebforward.org/docs/github-101.html. 109 http://testthewebforward.org/docs/github-101.html.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698