Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ash/shell.h

Issue 2690543003: Send notification to users upon receiving sms messages (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index 33b7ed6e70f5fb05ce3bef8a93a02e6bb6f7a0f5..510ff25decf42036d98281c6b1b1152c6b1bf63d 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -109,6 +109,7 @@ class ScreenPositionController;
class SessionStateDelegate;
struct ShellInitParams;
class ShutdownObserver;
+class SmsObserver;
class StickyKeysController;
class SystemGestureEventFilter;
class SystemModalContainerEventFilter;
@@ -131,6 +132,7 @@ class WindowWatcher;
namespace test {
class ShellTestApi;
+class SmsObserverTest;
}
// Shell is a singleton object that presents the Shell API and implements the
@@ -406,6 +408,7 @@ class ASH_EXPORT Shell : public SystemModalContainerEventFilterDelegate,
FRIEND_TEST_ALL_PREFIXES(WindowManagerTest, TransformActivate);
friend class RootWindowController;
friend class test::ShellTestApi;
+ friend class test::SmsObserverTest;
friend class shell::WindowWatcher;
explicit Shell(std::unique_ptr<WmShell> wm_shell);
@@ -526,6 +529,9 @@ class ASH_EXPORT Shell : public SystemModalContainerEventFilterDelegate,
// Listens for shutdown and updates DisplayConfigurator.
std::unique_ptr<ShutdownObserver> shutdown_observer_;
+ // Listens for new sms messages and display.
James Cook 2017/02/14 02:04:38 nit: "displays them" or "shows notifications".
yiyix 2017/02/15 19:41:39 Done.
+ std::unique_ptr<SmsObserver> sms_observer_;
+
// Implements content::ScreenOrientationController for Chrome OS.
std::unique_ptr<ScreenOrientationController> screen_orientation_controller_;
std::unique_ptr<ScreenLayoutObserver> screen_layout_observer_;

Powered by Google App Engine
This is Rietveld 408576698