Send notification to users upon receiving sms messages

ash/common/system/chromeos/network/sms_observer_unittest.cc

Index: ash/common/system/chromeos/network/sms_observer_unittest.cc
diff --git a/ash/common/system/chromeos/network/sms_observer_unittest.cc b/ash/common/system/chromeos/network/sms_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b43a01a6e60b85e71b07a67f1a81ef50262b6140
--- /dev/null
+++ b/ash/common/system/chromeos/network/sms_observer_unittest.cc
@@ -0,0 +1,135 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/system/chromeos/network/sms_observer.h"
+
+#include "ash/common/shelf/shelf_widget.h"
+#include "ash/common/shelf/wm_shelf.h"
+#include "ash/public/interfaces/vpn_list.mojom.h"
+#include "ash/shell.h"
+#include "ash/test/ash_test_base.h"
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/message_center/message_center.h"
+#include "ui/message_center/notification.h"
+#include "ui/message_center/notification_list.h"
+
+using message_center::MessageCenter;
+
+std::unique_ptr<base::DictionaryValue> CreateMessage(

[James Cook, 2017/02/14 02:04:38]

anonymous namespace again

[yiyix, 2017/02/15 19:41:39]

Done.

+    const char* kDefaultMessage = "FakeSMSClient: Test Message.",
+    const char* kDefaultNumber = "000-000-0000",
+    const char* kDefaultTimestamp = "Fri Jun  8 13:26:04 EDT 2016") {
+  std::unique_ptr<base::DictionaryValue> sms =
+      base::MakeUnique<base::DictionaryValue>();
+  if (kDefaultNumber)
+    sms->SetString("number", kDefaultNumber);
+  if (kDefaultMessage)
+    sms->SetString("text", kDefaultMessage);
+  if (kDefaultTimestamp)
+    sms->SetString("timestamp", kDefaultMessage);
+  return sms;
+}
+
+namespace ash {
+namespace test {

[James Cook, 2017/02/14 02:04:38]

super nit: Don't use this namespace. "namespace test" is for test helpers, not
for the tests themselves. Basically, it's for things that live in src/ash/test.

[yiyix, 2017/02/15 19:41:39]

Done.

+
+class SmsObserverTest : public AshTestBase {
+ public:
+  SmsObserverTest() {}
+  ~SmsObserverTest() override {}
+
+  SmsObserver* GetSmsObserver() {
+    Shell* shell = Shell::GetInstance();
+    return shell->sms_observer_.get();

[James Cook, 2017/02/14 02:04:38]

nit: just inline Shell::GetInstance()->sms_observer_.get()

[yiyix, 2017/02/15 19:41:39]

sorry, i was experimenting different ways to get shell forget to update it.

+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SmsObserverTest);
+};
+
+// Verify if notification is received after receiving a sms message with
+// number and content.
+TEST_F(SmsObserverTest, SendTextMessage) {
+  SmsObserver* sms_observer = GetSmsObserver();
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+
+  std::unique_ptr<base::DictionaryValue> sms(CreateMessage());
+  sms_observer->MessageReceived(*sms);
+
+  const message_center::NotificationList::Notifications notifications =
+      MessageCenter::Get()->GetVisibleNotifications();
+  EXPECT_EQ(1u, notifications.size());
+
+  EXPECT_EQ(base::ASCIIToUTF16("000-000-0000"),
+            (*notifications.begin())->title());
+  EXPECT_EQ(base::ASCIIToUTF16("FakeSMSClient: Test Message."),
+            (*notifications.begin())->message());
+  MessageCenter::Get()->RemoveAllNotifications(false /* by_user */,
+                                               MessageCenter::RemoveType::ALL);
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if phone number is missing in sms
+// message.
+TEST_F(SmsObserverTest, TextMessageMissingNumber) {
+  SmsObserver* sms_observer = GetSmsObserver();
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+
+  std::unique_ptr<base::DictionaryValue> sms(
+      CreateMessage("FakeSMSClient: Test Message.", nullptr));
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if text body is empty in sms message.
+TEST_F(SmsObserverTest, TextMessageEmptyText) {
+  SmsObserver* sms_observer = GetSmsObserver();
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+
+  std::unique_ptr<base::DictionaryValue> sms(CreateMessage(""));
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if the text is missing in sms message.
+TEST_F(SmsObserverTest, TextMessageMissingText) {
+  SmsObserver* sms_observer = GetSmsObserver();
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+  std::unique_ptr<base::DictionaryValue> sms(CreateMessage(nullptr));
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if 2 notification received after receiving 2 sms messages from the
+// same number.
+TEST_F(SmsObserverTest, MultipleTextMessages) {
+  SmsObserver* sms_observer = GetSmsObserver();
+  EXPECT_EQ(0u, MessageCenter::Get()->GetVisibleNotifications().size());
+
+  std::unique_ptr<base::DictionaryValue> sms(CreateMessage("first message"));
+  sms_observer->MessageReceived(*sms);
+  std::unique_ptr<base::DictionaryValue> sms2(CreateMessage("second message"));
+  sms_observer->MessageReceived(*sms2);
+  const message_center::NotificationList::Notifications notifications =
+      MessageCenter::Get()->GetVisibleNotifications();
+  EXPECT_EQ(2u, notifications.size());
+
+  for (message_center::Notification* iter : notifications) {
+    if (iter->id().find("chrome://network/sms1") != std::string::npos) {
+      EXPECT_EQ(base::ASCIIToUTF16("000-000-0000"), iter->title());
+      EXPECT_EQ(base::ASCIIToUTF16("first message"), iter->message());
+    } else if (iter->id().find("chrome://network/sms2") != std::string::npos) {
+      EXPECT_EQ(base::ASCIIToUTF16("000-000-0000"), iter->title());
+      EXPECT_EQ(base::ASCIIToUTF16("second message"), iter->message());
+    } else {
+      ASSERT_TRUE(false);
+    }
+  }
+}
+
+}  // namespace test
+}  // namespace ash