Send notification to users upon receiving sms messages

ash/common/shelf/shelf_widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SHELF_SHELF_WIDGET_H_
 #define ASH_COMMON_SHELF_SHELF_WIDGET_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
 #include "ash/common/shelf/shelf_background_animator.h"
 #include "ash/common/shelf/shelf_background_animator_observer.h"
 #include "ash/common/shelf/shelf_layout_manager_observer.h"
 #include "ash/public/cpp/shelf_types.h"
 #include "base/macros.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_observer.h"
 
 namespace app_list {
 class ApplicationDragAndDropHost;
 }
 
 namespace ash {
 class AppListButton;
 class FocusCycler;
 class ShelfLayoutManager;
 class ShelfView;
+class SmsObserver;
 class StatusAreaWidget;
 class WmShelf;
 class WmWindow;
 
+namespace test {
+class SmsObserverTest;
+}
+
 // The ShelfWidget manages the shelf view (which contains the shelf icons) and
 // the status area widget. There is one ShelfWidget per display. It is created
 // early during RootWindowController initialization.
 class ASH_EXPORT ShelfWidget : public views::Widget,
                                public views::WidgetObserver,
                                public ShelfBackgroundAnimatorObserver,
                                public ShelfLayoutManagerObserver {
  public:
   ShelfWidget(WmWindow* shelf_container, WmShelf* wm_shelf);
   ~ShelfWidget() override;
@@ skipping 54 matching lines @@
 
   // ShelfBackgroundAnimatorObserver overrides:
   void UpdateShelfItemBackground(int alpha) override;
 
   // ShelfLayoutManagerObserver overrides:
   void WillDeleteShelfLayoutManager() override;
 
  private:
   class DelegateView;
   friend class DelegateView;
+  friend class ash::test::SmsObserverTest;
 
   WmShelf* wm_shelf_;
 
   // Owned by the shelf container's window.
   ShelfLayoutManager* shelf_layout_manager_;
 
   // Owned by the native widget.
   StatusAreaWidget* status_area_widget_;
 
   // |delegate_view_| is the contents view of this widget and is cleaned up
   // during CloseChildWindows of the associated RootWindowController.
   DelegateView* delegate_view_;
   // View containing the shelf items. Owned by the views hierarchy. Null when
   // at the login screen.
   ShelfView* shelf_view_;
   ShelfBackgroundAnimator background_animator_;
+  std::unique_ptr<SmsObserver> sms_observer_;

[James Cook, 2017/02/10 17:36:37]

Why does SmsObserver live here? It seems like some class in the notification
system should subclass SmsObserver or should own an SmsObserver.

[stevenjb, 2017/02/10 17:48:26]

That's a good point. A more natural place for the to live would be:

chrome/browser/chromeos/net/

Alongside network_state_notifier.cc

Which is owned by NetworkConnectDelegateChromeOS which is owned by DBusServices
in chrome_browser_main_chromeos.cc.

Long term all of that may need to move to Ash, but for now I think it makes
sense for this to be owned by chrome_browser_main_chromeos.cc and instantiated
alongside NetworkConnectDelegateChromeOS.

   bool activating_as_fallback_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfWidget);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SHELF_SHELF_WIDGET_H_