Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 26905002: SK_ONCE for SkMatrix::I() (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
bungeman-skia, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SK_ONCE for SkMatrix::I() Going to start doing these in progressively larger and larger bulk, but I figured the first few changes probably merit caution. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11721

Patch Set 1 #

Patch Set 2 : pleasant note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/core/SkMatrix.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
7 years, 2 months ago (2013-10-10 18:30:00 UTC) #1
bungeman-skia
lgtm, even though it seems like there should be some means of initializing this statically ...
7 years, 2 months ago (2013-10-10 18:44:53 UTC) #2
mtklein
On 2013/10/10 18:44:53, bungeman1 wrote: > lgtm, even though it seems like there should be ...
7 years, 2 months ago (2013-10-10 18:47:37 UTC) #3
bsalomon
On 2013/10/10 18:47:37, mtklein wrote: > On 2013/10/10 18:44:53, bungeman1 wrote: > > lgtm, even ...
7 years, 2 months ago (2013-10-10 20:46:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26905002/4001
7 years, 2 months ago (2013-10-10 21:33:15 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 21:58:34 UTC) #6
Message was sent while issue was closed.
Change committed as 11721

Powered by Google App Engine
This is Rietveld 408576698