Issue 269048: SIGTERM should cause the application to exit on the Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269048: SIGTERM should cause the application to exit on the Mac (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

SIGTERM should cause the application to exit on the Mac. BUG=23551 TEST=Send SIGTERM to the browser process. It should exit cleanly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28695

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -8 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_list.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_list.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1 chunk	+29 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_application_mac.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_application_mac.mm	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Chris, here's a follow-up to your SIGTERM patch. This isn't crucial for the Mac because ...

11 years, 2 months ago (2009-10-12 02:53:50 UTC) #1

Chris Masone

11 years, 2 months ago (2009-10-12 04:26:57 UTC) #2

On 2009/10/12 02:53:50, Mark Mentovai wrote:
> Chris, here's a follow-up to your SIGTERM patch.  This isn't crucial for the
Mac
> because the OS' first attempt to kill an application doesn't use signals, but
> when we do get a SIGTERM, we should do something better than closing all
browser
> windows and then leaving the app up and usable.
> 
> I've also fixed the SIGTERM handler so that it'll actually kill the app on the
> first attempt if there's no main loop.

LGTM

Expand Messages | Collapse Messages