Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: content/common/service_manager/service_manager_connection_impl.cc

Issue 2690453002: mash: Fix shutdown hang in content_browser (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/service_manager/service_manager_connection_impl.cc
diff --git a/content/common/service_manager/service_manager_connection_impl.cc b/content/common/service_manager/service_manager_connection_impl.cc
index 4e511907808a5d42b03a251d4fc8bc4c876a9aeb..26f75d97eea463421adca445c7d69085695d5046 100644
--- a/content/common/service_manager/service_manager_connection_impl.cc
+++ b/content/common/service_manager/service_manager_connection_impl.cc
@@ -213,11 +213,10 @@ class ServiceManagerConnectionImpl::IOThreadContext
void RemoveConnectionFilterOnIOThread(int filter_id) {
base::AutoLock lock(lock_);
auto it = connection_filters_.find(filter_id);
- // TODO(crbug.com/687247): This DCHECK is hit when the browser is shut down
- // by the service manager (e.g. in response to an ash crash under mash).
- // Figure out why.
- DCHECK(it != connection_filters_.end());
- connection_filters_.erase(it);
+ // During shutdown the connection filters might have been cleared already
+ // by ClearConnectionFiltersOnIOThread() above, so this id might not exist.
+ if (it != connection_filters_.end())
+ connection_filters_.erase(it);
}
void OnBrowserConnectionLost() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698