chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc - Issue 2690443002: cros-md: Remove the non-MD immersive mode code paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Issue 2690443002: cros-md: Remove the non-MD immersive mode code paths (Closed)

Patch Set: remove pre-md tabstrip related code and fix Tabstrip::GetPreferredSize Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc ('K') | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

index bbd3db83638e230e7cde49adbdb51668ad437425..81850660916817e5c8a3ff77a5413431c4fc2c83 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

@@ -132,6 +132,8 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {

EXPECT_FALSE(toolbar->visible());

// The browser's top chrome is completely offscreen with tapstrip visible.

EXPECT_TRUE(tabstrip->visible());

+ // Top container view should be completely offscreen.

+ EXPECT_EQ(0, GetBoundsInWidget(browser_view()->top_container()).bottom());

// The tab indicators should be flush with the top of the widget.

EXPECT_EQ(0, GetBoundsInWidget(tabstrip).y());

@@ -145,7 +147,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {

AttemptReveal();

EXPECT_TRUE(controller()->IsRevealed());

EXPECT_TRUE(tabstrip->visible());

- EXPECT_FALSE(tabstrip->IsImmersiveStyle());

EXPECT_TRUE(toolbar->visible());

// The TopContainerView should be flush with the top edge of the widget. If

@@ -167,7 +168,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {

// should still be flush with the top edge of the widget.

EXPECT_TRUE(controller()->IsRevealed());

EXPECT_TRUE(tabstrip->visible());

- EXPECT_FALSE(tabstrip->IsImmersiveStyle());

EXPECT_TRUE(toolbar->visible());

EXPECT_EQ(0, GetBoundsInWidget(browser_view()->top_container()).y());

@@ -191,7 +191,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {

EXPECT_FALSE(controller()->IsEnabled());

EXPECT_FALSE(controller()->IsRevealed());

EXPECT_TRUE(tabstrip->visible());

- EXPECT_FALSE(tabstrip->IsImmersiveStyle());

EXPECT_TRUE(toolbar->visible());

}