Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4840)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Issue 2690443002: cros-md: Remove the non-MD immersive mode code paths (Closed)
Patch Set: based on sky@'s comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
index bbd3db83638e230e7cde49adbdb51668ad437425..febae7f665d4632d0e2045c3fce1bc13e0332ed9 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
@@ -132,9 +132,11 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {
EXPECT_FALSE(toolbar->visible());
// The browser's top chrome is completely offscreen with tapstrip visible.
EXPECT_TRUE(tabstrip->visible());
+ // Top container view should be completely offscreen.
+ EXPECT_EQ(0, GetBoundsInWidget(browser_view()->top_container()).bottom());
// The tab indicators should be flush with the top of the widget.
- EXPECT_EQ(0, GetBoundsInWidget(tabstrip).y());
+ EXPECT_EQ(0, GetBoundsInWidget(tabstrip).bottom());
// Since the tab strip and tool bar are both hidden in immersive fullscreen
// mode, the web contents should extend to the edge of screen.
@@ -145,7 +147,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {
AttemptReveal();
EXPECT_TRUE(controller()->IsRevealed());
EXPECT_TRUE(tabstrip->visible());
- EXPECT_FALSE(tabstrip->IsImmersiveStyle());
EXPECT_TRUE(toolbar->visible());
// The TopContainerView should be flush with the top edge of the widget. If
@@ -167,7 +168,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {
// should still be flush with the top edge of the widget.
EXPECT_TRUE(controller()->IsRevealed());
EXPECT_TRUE(tabstrip->visible());
- EXPECT_FALSE(tabstrip->IsImmersiveStyle());
EXPECT_TRUE(toolbar->visible());
EXPECT_EQ(0, GetBoundsInWidget(browser_view()->top_container()).y());
@@ -191,7 +191,6 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {
EXPECT_FALSE(controller()->IsEnabled());
EXPECT_FALSE(controller()->IsRevealed());
EXPECT_TRUE(tabstrip->visible());
- EXPECT_FALSE(tabstrip->IsImmersiveStyle());
EXPECT_TRUE(toolbar->visible());
}

Powered by Google App Engine
This is Rietveld 408576698