cros-md: Remove the non-MD immersive mode code paths

chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be

[tdanderson, 2017/02/14 17:14:38]

nit: please remove BUG=614453 from the CL description, the other two bug numbers
are sufficient for tracking

[Qiang(Joe) Xu, 2017/02/14 17:36:38]

Done.

 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_ASH_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_ASH_H_
 
 #include <memory>
 

[tdanderson, 2017/02/14 17:14:38]

One last place it looks like you've missed for full removal of the non-md
immersive mode code is in ShelfLayoutManager::ComputeTargetOpacity().

[Qiang(Joe) Xu, 2017/02/14 17:36:38]

Done.

 #include "ash/common/shell_observer.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "chrome/browser/ui/views/frame/browser_non_client_frame_view.h"
 #include "chrome/browser/ui/views/tab_icon_view_model.h"
 
 class TabIconView;
 
 namespace ash {
 class FrameCaptionButtonContainerView;
@@ skipping 60 matching lines @@
                            AvatarDisplayOnTeleportedWindow);
   friend class BrowserHeaderPainterAsh;
 
   // Distance between the left edge of the NonClientFrameView and the tab strip.
   int GetTabStripLeftInset() const;
 
   // Distance between the right edge of the NonClientFrameView and the tab
   // strip.
   int GetTabStripRightInset() const;
 
-  // Returns true if we should use a super short header with light bars instead
-  // of regular tabs. This header is used in immersive fullscreen when the
-  // top-of-window views are not revealed.
-  bool UseImmersiveLightbarHeaderStyle() const;
+  // Returns true if immersive mode is enabled and not revealed.
+  bool IsImmersiveFullscreenUnrevealed() const;
 
   // Returns true if the header should be painted so that it looks the same as
   // the header used for packaged apps. Packaged apps use a different color
   // scheme than browser windows.
   bool UsePackagedAppHeaderStyle() const;
 
   void LayoutProfileIndicatorIcon();
 
   // Returns true if there is anything to paint. Some fullscreen windows do not
   // need their frames painted.
   bool ShouldPaint() const;
 
   void PaintToolbarBackground(gfx::Canvas* canvas);
 
   // View which contains the window controls.
   ash::FrameCaptionButtonContainerView* caption_button_container_;
 
   // For popups, the window icon.
   TabIconView* window_icon_;
 
   // Helper class for painting the header.
   std::unique_ptr<ash::HeaderPainter> header_painter_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserNonClientFrameViewAsh);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_ASH_H_