Issue 2690423002: Make extra sure that _getMainClosure is set to the correct value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2690423002: Make extra sure that _getMainClosure is set to the correct value. (Closed)

Created:
3 years, 10 months ago by ahe

Modified:
3 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Project:
Fasta

Visibility:
Public.

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/front_end/lib/src/fasta/kernel/kernel_target.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Total messages: 5 (2 generated)

ahe

Last change needed to run hello.dart with --compile-sdk. The reason why I have to call ...

3 years, 10 months ago (2017-02-14 18:15:50 UTC) #2

Siggi Cherem (dart-lang)

lgtm - I believe the plan is to get rid of this transform altogether (have ...

3 years, 10 months ago (2017-02-14 20:08:20 UTC) #3

ahe

3 years, 10 months ago (2017-02-15 08:06:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
40604876fe11d5f904591ffbc062949b6312ed53 (presubmit successful).