Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart

Issue 2690393002: Remove noisy warning. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.dill_library_builder; 5 library fasta.dill_library_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 Class, 8 Class,
9 ExpressionStatement, 9 ExpressionStatement,
10 Field, 10 Field,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 classBulder.addMember(field); 82 classBulder.addMember(field);
83 } 83 }
84 } 84 }
85 } 85 }
86 86
87 void addMember(Member member) { 87 void addMember(Member member) {
88 String name = member.name.name; 88 String name = member.name.name;
89 if (name == "_exports#") { 89 if (name == "_exports#") {
90 // This is a hack / work around for storing exports in dill files. See 90 // This is a hack / work around for storing exports in dill files. See
91 // [compile_platform.dart](../compile_platform.dart). 91 // [compile_platform.dart](../compile_platform.dart).
92 print("$uri: _exports# not implemented yet.");
93 } else { 92 } else {
94 addBuilder(name, new DillMemberBuilder(member, this), member.fileOffset); 93 addBuilder(name, new DillMemberBuilder(member, this), member.fileOffset);
95 } 94 }
96 } 95 }
97 96
98 Builder addBuilder(String name, Builder builder, int charOffset) { 97 Builder addBuilder(String name, Builder builder, int charOffset) {
99 if (name == null || name.isEmpty) return null; 98 if (name == null || name.isEmpty) return null;
100 members[name] = builder; 99 members[name] = builder;
101 if (!name.startsWith("_")) { 100 if (!name.startsWith("_")) {
102 exports[name] = builder; 101 exports[name] = builder;
103 } 102 }
104 return builder; 103 return builder;
105 } 104 }
106 105
107 bool addToExportScope(String name, Builder member) { 106 bool addToExportScope(String name, Builder member) {
108 return internalError("Not implemented yet."); 107 return internalError("Not implemented yet.");
109 } 108 }
110 109
111 void addToScope(String name, Builder member) { 110 void addToScope(String name, Builder member) {
112 internalError("Not implemented yet."); 111 internalError("Not implemented yet.");
113 } 112 }
114 113
115 KernelInvalidTypeBuilder buildAmbiguousBuilder( 114 KernelInvalidTypeBuilder buildAmbiguousBuilder(
116 String name, Builder builder, Builder other, int charOffset) { 115 String name, Builder builder, Builder other, int charOffset) {
117 return new KernelInvalidTypeBuilder(name, charOffset, fileUri); 116 return new KernelInvalidTypeBuilder(name, charOffset, fileUri);
118 } 117 }
119 } 118 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698