components/offline_items_collection/BUILD.gn - Issue 2690333002: Initial checkin of OfflineContentProvider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_items_collection/BUILD.gn

Issue 2690333002: Initial checkin of OfflineContentProvider. (Closed)

Patch Set: Address dcheng comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 static_library("offline_items_collection") {
	brettw 2017/03/06 18:35:49 Some systems will complain about static libraries Some systems will complain about static libraries with no sources (this is causing some of the mac failures in the previous try runs). This should probably be a group. David Trainor- moved to gerrit 2017/03/06 19:03:20 Done. Show quoted text On 2017/03/06 18:35:49, brettw (plz ping after 24h) wrote: > Some systems will complain about static libraries with no sources (this is > causing some of the mac failures in the previous try runs). This should probably > be a group. Done.
	6 deps = [

	7 "//components/offline_items_collection/core",

	8 ]

	9 }

	10

	11 group("unit_tests") {

	12 testonly = true

	13

	14 deps = [

	15 "//components/offline_items_collection/core:unit_tests",

	16 ]

	17 }

OLD	NEW