Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: components/omnibox/browser/in_memory_url_index_types.h

Issue 2690303012: Cleaning up url_index_private_data and in_memory_url_index_types. (Closed)
Patch Set: Dropping noexcept from move operations. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/in_memory_url_index_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/in_memory_url_index_types.h
diff --git a/components/omnibox/browser/in_memory_url_index_types.h b/components/omnibox/browser/in_memory_url_index_types.h
index 070ba43bf621896e2bdf4c18ec71ead2678ff4b0..6d38a79f9c7a001b762845cc38cc85175c77e5da 100644
--- a/components/omnibox/browser/in_memory_url_index_types.h
+++ b/components/omnibox/browser/in_memory_url_index_types.h
@@ -147,6 +147,9 @@ typedef std::vector<history::VisitInfo> VisitInfoVector;
struct HistoryInfoMapValue {
HistoryInfoMapValue();
HistoryInfoMapValue(const HistoryInfoMapValue& other);
+ HistoryInfoMapValue(HistoryInfoMapValue&& other);
+ HistoryInfoMapValue& operator=(const HistoryInfoMapValue& other);
+ HistoryInfoMapValue& operator=(HistoryInfoMapValue&& other);
~HistoryInfoMapValue();
// This field is always populated.
@@ -166,6 +169,9 @@ typedef base::hash_map<HistoryID, HistoryInfoMapValue> HistoryInfoMap;
struct RowWordStarts {
RowWordStarts();
RowWordStarts(const RowWordStarts& other);
+ RowWordStarts(RowWordStarts&& other);
+ RowWordStarts& operator=(const RowWordStarts& other);
+ RowWordStarts& operator=(RowWordStarts&& other);
~RowWordStarts();
// Clears both url_word_starts_ and title_word_starts_.
« no previous file with comments | « no previous file | components/omnibox/browser/in_memory_url_index_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698