Add option to GRIT to provide a resource ordering input file.

tools/grit/grit/tool/build.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''The 'grit build' tool along with integration for this tool with the
 SCons build system.
 '''
 
 import codecs
@@ skipping 67 matching lines @@
 
   --assert-file-list  Provide a file listing multiple asserted output files.
                     There is one file name per line. This acts like specifying
                     each file with "-a" on the command line, but without the
                     possibility of running into OS line-length limits for very
                     long lists.
 
   -o OUTPUTDIR      Specify what directory output paths are relative to.
                     Defaults to the current directory.
 
+  -p FILE           Specify a file containing a pre-determined mapping from
+                    resource names to resource ids which will be used to assign
+                    resource ids to those resources. Resources not found in this
+                    file will assigned ids normally. The file is of the format:

[Nico, 2017/02/17 21:44:08]

s/will/will be/

Have you considered if missing IDs should be an error instead of automatically
getting an ID assigned? Why the "silently do a suboptimal thing" decision?
(There might be a good reason, just want to know it)

[Alexei Svitkine (slow), 2017/02/17 22:07:51]

Done.
Yep. The order file only has resources that are loaded during startup. Without
data from the wild, we don't know what an optimal order is for the other ids -
so there's no point in re-assigning them to something arbitrary.

+                      RESOURCE_ONE_NAME 123
+                      RESOURCE_TWO_NAME 124
+
   -D NAME[=VAL]     Specify a C-preprocessor-like define NAME with optional
                     value VAL (defaults to 1) which will be used to control
                     conditional inclusion of resources.
 
   -E NAME=VALUE     Set environment variable NAME to VALUE (within grit).
 
   -f FIRSTIDSFILE   Path to a python file that specifies the first id of
                     value to use for resources.  A non-empty value here will
                     override the value specified in the <grit> node's
                     first_ids_file.
@@ skipping 41 matching lines @@
 IDs).  This helps ensure that values of IDs stay the same, that all messages
 are exported to translation interchange files (e.g. XMB files), etc.
 '''
 
   def ShortDescription(self):
     return 'A tool that builds RC files for compilation.'
 
   def Run(self, opts, args):
     self.output_directory = '.'
     first_ids_file = None
+    predetermined_ids_file = None
     whitelist_filenames = []
     assert_output_files = []
     target_platform = None
     depfile = None
     depdir = None
     rc_header_format = None
     output_all_resource_defines = None
     write_only_new = False
     depend_on_stamp = False
     js_minifier = None
     replace_ellipsis = True
-    (own_opts, args) = getopt.getopt(args, 'a:o:D:E:f:w:t:h:',
+    (own_opts, args) = getopt.getopt(args, 'a:p:o:D:E:f:w:t:h:',
         ('depdir=','depfile=','assert-file-list=',
          'output-all-resource-defines',
          'no-output-all-resource-defines',
          'no-replace-ellipsis',
          'depend-on-stamp',
          'js-minifier=',
          'write-only-new='))
     for (key, val) in own_opts:
       if key == '-a':
         assert_output_files.append(val)
@@ skipping 14 matching lines @@
         # .grd itself.
         first_ids_file = val
       elif key == '-w':
         whitelist_filenames.append(val)
       elif key == '--output-all-resource-defines':
         output_all_resource_defines = True
       elif key == '--no-output-all-resource-defines':
         output_all_resource_defines = False
       elif key == '--no-replace-ellipsis':
         replace_ellipsis = False
+      elif key == '-p':
+        predetermined_ids_file = val
       elif key == '-t':
         target_platform = val
       elif key == '-h':
         rc_header_format = val
       elif key == '--depdir':
         depdir = val
       elif key == '--depfile':
         depfile = val
       elif key == '--write-only-new':
         write_only_new = val != '0'
@@ skipping 21 matching lines @@
         self.whitelist_names.update(whitelist_contents.strip().split('\n'))
 
     if js_minifier:
       minifier.SetJsMinifier(js_minifier)
 
     self.write_only_new = write_only_new
 
     self.res = grd_reader.Parse(opts.input,
                                 debug=opts.extra_verbose,
                                 first_ids_file=first_ids_file,
+                                predetermined_ids_file=predetermined_ids_file,
                                 defines=self.defines,
                                 target_platform=target_platform)
 
     # If the output_all_resource_defines option is specified, override the value
     # found in the grd file.
     if output_all_resource_defines is not None:
       self.res.SetShouldOutputAllResourceDefines(output_all_resource_defines)
 
     # Set an output context so that conditionals can use defines during the
     # gathering stage; we use a dummy language here since we are not outputting
@@ skipping 269 matching lines @@
     self.MakeDirectoriesTo(depfile)
     outfile = self.fo_create(depfile, 'w', encoding='utf-8')
     outfile.writelines(depfile_contents)
 
   @staticmethod
   def MakeDirectoriesTo(file):
     '''Creates directories necessary to contain |file|.'''
     dir = os.path.split(file)[0]
     if not os.path.exists(dir):
       os.makedirs(dir)