Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6121)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2690263002: MD Settings: add empty list message for spell-check edit page. (Closed)
Patch Set: fix 80 col Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 76147b05e34164593d2635b38b5e130aa8169eef..f626a67d80a39a7d0d75d985200ccebd79e56560 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -350,7 +350,6 @@ Polymer({
onEditDictionaryTap_: function() {
assert(!cr.isMac);
settings.navigateTo(settings.Route.EDIT_DICTIONARY);
- this.forceRenderList_('settings-edit-dictionary-page');
},
/**
@@ -456,16 +455,6 @@ Polymer({
},
/**
- * HACK(michaelpg): This is necessary to show the list when navigating to
- * the sub-page. Remove this function when PolymerElements/neon-animation#60
- * is fixed.
- * @param {string} tagName Name of the element containing the <iron-list>.
- */
scottchen 2017/02/15 19:34:46 This is fixed now so we can remove it.
dpapad 2017/02/15 20:36:37 Can you elaborate how you verified that this works
scottchen 2017/02/22 21:42:25 michaelpg@ says the iron list used to not show up
- forceRenderList_: function(tagName) {
- this.$$(tagName).$$('iron-list').fire('iron-resize');
- },
-
- /**
* @param {!Event} e
* @private
*/

Powered by Google App Engine
This is Rietveld 408576698