Issue 269023005: - Ensure that BaseIsolate is only used to break the header include cycles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269023005: - Ensure that BaseIsolate is only used to break the header include cycles. (Closed)

Created:
6 years, 7 months ago by Ivan Posva

Modified:
6 years, 7 months ago

Reviewers:
koda, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Ensure that BaseIsolate is only used to break the header include cycles. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35770

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -23 lines)			Patch
M	runtime/vm/allocation.h	View	1 chunk	+14 lines, -11 lines	2 comments	Download
M	runtime/vm/handles.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/handles.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/timer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/zone.h	View	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r35770 (presubmit successful).

6 years, 7 months ago (2014-05-05 21:45:42 UTC) #3

koda

https://codereview.chromium.org/269023005/diff/1/runtime/vm/allocation.h File runtime/vm/allocation.h (right): https://codereview.chromium.org/269023005/diff/1/runtime/vm/allocation.h#newcode40 runtime/vm/allocation.h:40: : isolate_(reinterpret_cast<BaseIsolate*>(isolate)), previous_(NULL) { Use implicit_cast from platform/globals.h. https://codereview.chromium.org/269023005/diff/1/runtime/vm/allocation.h#newcode66 ...

6 years, 7 months ago (2014-05-05 21:51:27 UTC) #4

koda

6 years, 7 months ago (2014-05-05 22:07:00 UTC) #5

Message was sent while issue was closed.

lgtm

As you pointed out, you probably cannot use them since Isolate is only
forward-declared.

Expand Messages | Collapse Messages