chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java - Issue 2690163008: Route through a JobService when receiving a message for the GCM Driver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java

Issue 2690163008: Route through a JobService when receiving a message for the GCM Driver (Closed)

Patch Set: Route through a JobService when receiving a message for the GCM Driver Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/JobSchedulerConstants.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java

index 10bb8872fa1845f82d6d0d5e2db4dfd1aec05e08..cf8de4f269637e4cff2201f44f66965b158a5344 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java

@@ -20,10 +20,6 @@ import org.chromium.base.ThreadUtils;

@TargetApi(Build.VERSION_CODES.N)

public class NotificationJobService extends JobService {

- // We don't need to distinguish between jobs sent to this service, so we can reuse one job id.

- // But it ought to be distinct from job ids used with other JobService classes in our code.

- static final int JOB_ID = 21;

static PersistableBundle getJobExtrasFromIntent(Intent intent) {

PersistableBundle bundle = new PersistableBundle();

bundle.putString(NotificationConstants.EXTRA_NOTIFICATION_ID,