Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

Issue 2690163008: Route through a JobService when receiving a message for the GCM Driver (Closed)
Patch Set: findbugs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
index ecd8c0a607c5a08adf8cb70a40801887a1bcc6a1..e712a7b853c9a7d35ee557450a82bc88c33b5bff 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
@@ -33,7 +33,10 @@ public class CrashReceiverService extends Service {
private static final String WEBVIEW_CRASH_DIR = "WebView_Crashes";
private static final String WEBVIEW_TMP_CRASH_DIR = "WebView_Crashes_Tmp";
- private static final int MINIDUMP_UPLOADING_JOB_ID = 42;
+ // Job ID used to schedule the minidump uploading job with the Android JobScheduler. Must be
+ // unique in Chromium, see org.chromium.chrome.browser.JobSchedulerConstants.
+ private static final int MINIDUMP_UPLOADING_JOB_ID = 2;
nyquist 2017/02/22 11:38:02 Do we need to change this ID? Wouldn't the comment
Peter Beverloo 2017/02/23 17:26:55 Done.
+
// Initial back-off time for upload-job, this is set to a fairly high number (30 minutes) to
// increase the chance of performing uploads in batches if the initial upload fails.
private static final int JOB_BACKOFF_TIME_IN_MS = 1000 * 60 * 30;

Powered by Google App Engine
This is Rietveld 408576698