services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h - Issue 2690143004: NOCOMMIT: Rebased https://codereview.chromium.org/2696503004 on service rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

Issue 2690143004: NOCOMMIT: Rebased https://codereview.chromium.org/2696503004 on service rename

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc ('k') | services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

diff --git a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

index 117661997368983b166c9a275728e054f488a42b..40c9be7b4f03479e77f7cdd62313201d2e2dc0c8 100644

--- a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

+++ b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

@@ -26,7 +26,9 @@ class MemoryDumpManagerDelegateImpl

MemoryDumpManagerDelegateImpl(Coordinator* coordinator);

~MemoryDumpManagerDelegateImpl() override;

- bool IsCoordinator() const;

+ bool IsCoordinator() const override;

+ // TODO(chiniforooshan): delete.

+ uint64_t GetTracingProcessId() const override;

// The base::trace_event::MemoryDumpManager calls this.

void RequestGlobalMemoryDump(