Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 269013006: Avoid unnecessary width recalculation after bug fixed (Closed)

Created:
6 years, 7 months ago by ltilve
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid unnecessary width recalculation after bug fixed The issue http://crbug.com/237700 which was causing an infinite loop is a duplicate of http://crbug.com/238405 which has already been fixed, making unnecessary the workaround. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/message_center/views/bounded_label.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ltilve
There was a TODO requesting to eliminate some code when the bug http://crbug.com/237700 had been ...
6 years, 7 months ago (2014-05-05 21:21:51 UTC) #1
stevenjb
This looks OK to me. +mukai@ who may have looked at this code more recently, ...
6 years, 7 months ago (2014-05-05 21:24:10 UTC) #2
Jun Mukai
The change itself looks good but I don't have much knowledge around this part. Since ...
6 years, 7 months ago (2014-05-05 21:30:16 UTC) #3
ltilve
On 2014/05/05 21:30:16, Jun Mukai wrote: > The change itself looks good but I don't ...
6 years, 7 months ago (2014-05-13 18:52:51 UTC) #4
Dmitry Titov
I'm terribly sorry, it got off my radar. Looking... On Tue, May 13, 2014 at ...
6 years, 7 months ago (2014-05-13 19:42:11 UTC) #5
Dmitry Titov
LGTM
6 years, 7 months ago (2014-05-13 19:43:50 UTC) #6
ltilve
The CQ bit was checked by ltilve@igalia.com
6 years, 7 months ago (2014-05-13 21:43:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ltilve@igalia.com/269013006/1
6 years, 7 months ago (2014-05-13 21:45:24 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 23:45:49 UTC) #9
Message was sent while issue was closed.
Change committed as 270249

Powered by Google App Engine
This is Rietveld 408576698