Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: content/shell/app/shell_main_delegate.cc

Issue 2690113010: Abstract OSMesa from the Layout tests (Closed)
Patch Set: Fixed test code Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/app/shell_main_delegate.cc
diff --git a/content/shell/app/shell_main_delegate.cc b/content/shell/app/shell_main_delegate.cc
index 28ce63b61a2ab9e8cf32e7f20b97a80ccd17e432..84f0ad385c651bddf352c68f8393adab8b5d3c5b 100644
--- a/content/shell/app/shell_main_delegate.cc
+++ b/content/shell/app/shell_main_delegate.cc
@@ -42,6 +42,7 @@
#include "ui/base/ui_base_paths.h"
#include "ui/base/ui_base_switches.h"
#include "ui/display/display_switches.h"
+#include "ui/gl/gl_implementation.h"
#include "ui/gl/gl_switches.h"
#include "ipc/ipc_message.h" // For IPC_MESSAGE_LOG_ENABLED.
@@ -167,11 +168,12 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
command_line.AppendSwitch(switches::kProcessPerTab);
command_line.AppendSwitch(switches::kEnableLogging);
command_line.AppendSwitch(switches::kAllowFileAccessFromFiles);
- // only default to osmesa if the flag isn't already specified.
+ // only default to a software renderer if the flag isn't already specified.
if (!command_line.HasSwitch(switches::kUseGpuInTests) &&
!command_line.HasSwitch(switches::kUseGL)) {
- command_line.AppendSwitchASCII(switches::kUseGL,
- gl::kGLImplementationOSMesaName);
+ command_line.AppendSwitchASCII(
+ switches::kUseGL,
+ gl::GetGLImplementationName(gl::GetSoftwareGLImplementation()));
}
command_line.AppendSwitch(switches::kSkipGpuDataLoading);
command_line.AppendSwitchASCII(

Powered by Google App Engine
This is Rietveld 408576698