Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: net/socket/tcp_socket_posix.h

Issue 2690113004: Throttle Socket watcher RTT notifications from QUIC (Closed)
Patch Set: Rebased, rch comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_network_transaction_unittest.cc ('k') | net/socket/tcp_socket_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_socket_posix.h
diff --git a/net/socket/tcp_socket_posix.h b/net/socket/tcp_socket_posix.h
index fda90fcfd95644b052dbc6ce40f391172c57d330..93b8261a1f425f6b8b7e258cd7fa177ef5fe7005 100644
--- a/net/socket/tcp_socket_posix.h
+++ b/net/socket/tcp_socket_posix.h
@@ -12,7 +12,6 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "base/time/time.h"
#include "net/base/address_family.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
@@ -20,7 +19,7 @@
#include "net/socket/socket_performance_watcher.h"
namespace base {
-class TickClock;
+class TimeDelta;
}
namespace net {
@@ -108,8 +107,6 @@ class NET_EXPORT TCPSocketPosix {
void StartLoggingMultipleConnectAttempts(const AddressList& addresses);
void EndLoggingMultipleConnectAttempts(int net_error);
- void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock);
-
const NetLogWithSource& net_log() const { return net_log_; }
private:
@@ -224,16 +221,6 @@ class NET_EXPORT TCPSocketPosix {
// |socket_performance_watcher_|. May be nullptr.
std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher_;
- std::unique_ptr<base::TickClock> tick_clock_;
-
- // Minimum interval betweeen consecutive notifications to
- // |socket_performance_watcher_|.
- const base::TimeDelta rtt_notifications_minimum_interval_;
-
- // Time when the |socket_performance_watcher_| was last notified of updated
- // RTT.
- base::TimeTicks last_rtt_notification_;
-
// Enables experimental TCP FastOpen option.
bool use_tcp_fastopen_;
« no previous file with comments | « net/quic/chromium/quic_network_transaction_unittest.cc ('k') | net/socket/tcp_socket_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698