Issue 26901003: Redo the python check to look for the directories too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26901003: Redo the python check to look for the directories too. (Closed)

Created:
7 years, 2 months ago by M-A Ruel

Modified:
7 years, 2 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Redo the python check to look for the directories too. This way, DEPOT_TOOLS_PYTHON_275=1 will properly upgrade an installation still running 2.6. Otherwise the user had to "del python.bat" to force the upgrade. Stop calling python to verify it works, this is slow. Upgrade url to https. R=iannucci@chromium.org BUG=241769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228179

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
	M	bootstrap/win/win_tools.bat	View		2 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r228179.

Expand Messages | Collapse Messages