Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: pkg/front_end/test/scanner_fasta_test.dart

Issue 2690073003: When translating analyzer/fasta token streams, match up begin/end tokens. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/scanner_fasta_test.dart
diff --git a/pkg/front_end/test/scanner_fasta_test.dart b/pkg/front_end/test/scanner_fasta_test.dart
index f8704d3a4f5e6bff7ae62dfce3b6e64f88d19a74..ca3ccb09adc5c0a6bf570dd7fe0cccd56ba2881f 100644
--- a/pkg/front_end/test/scanner_fasta_test.dart
+++ b/pkg/front_end/test/scanner_fasta_test.dart
@@ -91,6 +91,22 @@ class ScannerTest_Fasta extends ScannerTestBase {
@override
@failingTest
+ void test_mismatched_closer() {
+ // TODO(paulberry,ahe): Fasta and analyzer recover this error differently.
+ // Figure out which recovery technique we want the front end to use.
Paul Berry 2017/02/13 22:38:59 FWIW, my intuition is that Fasta's error recovery
ahe 2017/02/14 11:28:32 That also has its downsides, but I have some ideas
+ super.test_mismatched_closer();
+ }
+
+ @override
+ @failingTest
+ void test_mismatched_opener() {
+ // TODO(paulberry,ahe): Fasta and analyzer recover this error differently.
+ // Figure out which recovery technique we want the front end to use.
+ super.test_mismatched_opener();
+ }
+
+ @override
+ @failingTest
void test_scriptTag_withArgs() {
// TODO(paulberry,ahe): script tags are needed by analyzer.
super.test_scriptTag_withArgs();

Powered by Google App Engine
This is Rietveld 408576698