tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart - Issue 2690063002: Refactor CompilerOutput

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart

Issue 2690063002: Refactor CompilerOutput (Closed)

Patch Set: Updated cf. comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart ('k') | tests/compiler/dart2js/deferred_emit_type_checks_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart

diff --git a/tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart b/tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart

index 4bf5bb6be504065c7cf9dfe2fc4f93373da89707..7259691d48bf869c61bae638fb4ed54362af7004 100644

--- a/tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart

+++ b/tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart

@@ -6,6 +6,7 @@

// Files when using deferred loading.

import 'package:async_helper/async_helper.dart';

+import 'package:compiler/compiler_new.dart';

import 'package:compiler/src/compiler.dart';

import 'package:expect/expect.dart';

import 'memory_compiler.dart';

@@ -31,8 +32,9 @@ void main() {

var foo1 = lib1.find("finalVar");

var ou_lib1 = outputUnitForElement(foo1);

- String mainOutput = collector.getOutput("", "js");

- String lib1Output = collector.getOutput("out_${ou_lib1.name}", "part.js");

+ String mainOutput = collector.getOutput("", OutputType.js);

+ String lib1Output =

+ collector.getOutput("out_${ou_lib1.name}", OutputType.jsPart);

// Test that the deferred globals are not inlined into the main file.

RegExp re1 = new RegExp(r"= .string1");

RegExp re2 = new RegExp(r"= .string2");