Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2690063002: Refactor CompilerOutput (Closed)
Patch Set: Updated cf. comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/dump_info.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart2js.dart
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
index 812460a3e2340660dba8be384383c923f82d5182..77910e27cc4e572a159281486d1548c2b84df52b 100644
--- a/pkg/compiler/lib/src/dart2js.dart
+++ b/pkg/compiler/lib/src/dart2js.dart
@@ -1003,16 +1003,17 @@ class _SerializedData {
class _CompilerOutput extends NullCompilerOutput {
final Uri uri;
- _BufferedEventSink sink;
+ _BufferedOutputSink sink;
_CompilerOutput(this.uri);
@override
- EventSink<String> createEventSink(String name, String extension) {
+ api.OutputSink createOutputSink(
+ String name, String extension, api.OutputType type) {
if (name == '' && extension == 'data') {
- return sink = new _BufferedEventSink();
+ return sink = new _BufferedOutputSink();
}
- return super.createEventSink(name, extension);
+ return super.createOutputSink(name, extension, type);
}
_SerializedData get serializedData {
@@ -1020,7 +1021,7 @@ class _CompilerOutput extends NullCompilerOutput {
}
}
-class _BufferedEventSink implements EventSink<String> {
+class _BufferedOutputSink implements api.OutputSink {
StringBuffer sb = new StringBuffer();
@override
@@ -1032,9 +1033,4 @@ class _BufferedEventSink implements EventSink<String> {
void close() {
// Do nothing.
}
-
- @override
- void addError(errorEvent, [StackTrace stackTrace]) {
- // Ignore
- }
}
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/dump_info.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698