Issue 269004: X64: Convert doubles to int32 inline (without calling runtime).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269004: X64: Convert doubles to int32 inline (without calling runtime).

Created:
11 years, 2 months ago by Lasse Reichstein

Modified:
11 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

X64: Convert doubles to int32 inline (without calling runtime).

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+217 lines, -89 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	5 chunks	+138 lines, -88 lines	1 comment	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+60 lines, -0 lines	1 comment	Download
M	test/cctest/SConscript	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Please delay reviewing until benchmark results come in, and are positive.

11 years, 2 months ago (2009-10-07 10:44:28 UTC) #1

Lasse Reichstein

11 years, 2 months ago (2009-10-07 16:54:24 UTC) #2

Benchmarks looks promising. Please do review.

http://codereview.chromium.org/269004/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/269004/diff/1/3#newcode7593
Line 7593: Label skip_allocation, non_smi_result, operand_conversion_failure;
I'm considering using CheckFloatOperands first, to avoid converting one operand
and then going to the runtime if the other is a non-number. It will double the
smi checks, though.

http://codereview.chromium.org/269004/diff/1/4
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/269004/diff/1/4#newcode291
Line 291: subl(kScratchRegister, Immediate(1));
Just noticed that the previous two lines could be done with one lea instruction.

Expand Messages | Collapse Messages