Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 26900006: Rename Node::willBeDeletedFrom() to willBeDeletedFromDocument() (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, Hajime Morrita, adamk
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Rename Node::willBeDeletedFrom() to willBeDeletedFromDocument() Rename Node::willBeDeletedFrom() to willBeDeletedFromDocument() and remove argument since it is always called with the current Node's document. Also make willBeDeletedFromDocument() protected. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160364

Patch Set 1 #

Total comments: 1

Patch Set 2 : Take comments into consideration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 chunks +10 lines, -11 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
7 years, 2 months ago (2013-10-16 17:00:14 UTC) #1
adamk
This is fine, but I think this method could use some rethinking. We always pass ...
7 years, 2 months ago (2013-10-16 17:15:17 UTC) #2
Hajime Morrita
On 2013/10/16 17:15:17, adamk wrote: > This is fine, but I think this method could ...
7 years, 2 months ago (2013-10-23 06:09:13 UTC) #3
Inactive
I took the feedback into consideration. Please take another look.
7 years, 2 months ago (2013-10-23 17:55:39 UTC) #4
adamk
thanks, lgtm!
7 years, 2 months ago (2013-10-23 18:33:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26900006/17001
7 years, 2 months ago (2013-10-23 18:36:40 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 19:33:06 UTC) #7
Message was sent while issue was closed.
Change committed as 160364

Powered by Google App Engine
This is Rietveld 408576698