chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 2689993002: Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2689993002: Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager (Closed)

Patch Set: Make some changes according to review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeShortcutManager.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 3e52909b2deb94006fc41a33756fa8341abf0a9d..8d57540f3e7e9e5c928b75b8336217785b43e2fb 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.banners;

import android.app.Activity;

import android.app.Instrumentation.ActivityMonitor;

import android.app.Instrumentation.ActivityResult;

-import android.content.Context;

import android.content.Intent;

import android.content.IntentFilter;

import android.content.pm.PackageInfo;

@@ -182,7 +181,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

AppBannerInfoBarDelegateAndroid.setPackageManagerForTesting(mPackageManager);

ShortcutHelper.setDelegateForTests(new ShortcutHelper.Delegate() {

@Override

- public void sendBroadcast(Context context, Intent intent) {

+ public void addShortcutToHomescreen(String title, Bitmap icon, Intent shortcutIntent) {

// Ignore to prevent adding homescreen shortcuts.

}

});