chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2689993002: Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2689993002: Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager (Closed)

Patch Set: Change according to review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index d72051fda974fcb1a8dde4b2718dfd4b07361938..040ceaab4d810b86682c5f3b2b88879706a2fdce 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -163,7 +163,7 @@ public class AppMenuPropertiesDelegate {

// is not persisted when adding to the homescreen.

// * If creating shortcuts it not supported by the current home screen.

MenuItem homescreenItem = menu.findItem(R.id.add_to_homescreen_id);

- boolean homescreenItemVisible = ShortcutHelper.isAddToHomeIntentSupported(mActivity)

+ boolean homescreenItemVisible = ShortcutHelper.isAddToHomeIntentSupported()

&& !isChromeScheme && !isFileScheme && !isContentScheme && !isIncognito;

if (homescreenItemVisible) {

homescreenItem.setTitle(AppBannerManager.getHomescreenLanguageOption());