Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager

chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeShortcutManager.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.webapps;
+
+import android.annotation.SuppressLint;
+import android.content.Intent;
+import android.content.pm.PackageManager;
+import android.content.pm.ResolveInfo;
+import android.graphics.Bitmap;
+
+import org.chromium.base.ContextUtils;
+import org.chromium.chrome.browser.ChromeApplication;
+
+import java.util.List;
+
+/**
+ * This class helps to add a shortcut to the Android Home Screen.  It also tells if
+ * addShortcutToHomeScreen is supported or not.

[gone, 2017/02/15 19:40:19]

1) Don't need to enumerate everything it does.  Just say it handles adding
shortcuts to the home screen, or something.

2) This class doesn't actually manage shortcuts; it just adds them.  Maybe call
it a ChromeShortcutHelper or ShortcutCreationDelegate or something

[Marti Wong, 2017/02/17 05:10:49]

It's really hard to think of a new name without confusing with ShortcutHelper or
ShortcutHelper.Delegate.
And this class will be merged up to ShortcutHelper in future CL.  So I'd like to
keep its name as it.

[gone, 2017/02/17 19:41:43]

Acknowledged.

+ */
+public class ChromeShortcutManager {
+    private static ChromeShortcutManager sInstance;

[gone, 2017/02/15 19:40:19]

nit: move private static below private static final

[Marti Wong, 2017/02/17 05:10:49]

Done.

+
+    // There is no public string defining this intent so if Home changes the value, we
+    // have to update this string.
+    private static final String INSTALL_SHORTCUT = "com.android.launcher.action.INSTALL_SHORTCUT";
+
+    /* Returns the singleton instance of ChromeShortcutManager, creating it if needed. */
+    public static ChromeShortcutManager getInstance() {
+        if (sInstance == null) {
+            sInstance = ((ChromeApplication) ContextUtils.getApplicationContext()
+                                 .getApplicationContext())
+                                .createChromeShortcutManager();

[gone, 2017/02/15 19:40:19]

1) is this a git cl format thing?  really struggling to understand how it
decides how to indent in these cases.

2) don't get the application context from the application context.

[Marti Wong, 2017/02/17 05:10:49]

Sorry about that. fixed.

+        }
+        return sInstance;
+    }
+
+    /**
+     * Creates an intent that will add a shortcut to the home screen.
+     * @param title Title of the shortcut.

[gone, 2017/02/15 19:40:19]

nit: line up params?

[Marti Wong, 2017/02/17 05:10:49]

Done.

+     * @param icon Image that represents the shortcut.
+     * @param shortcutIntent Intent to fire when the shortcut is activated.
+     * @return Intent for the shortcut.
+     */
+    public static Intent createAddToHomeIntent(String title, Bitmap icon, Intent shortcutIntent) {
+        Intent i = new Intent(INSTALL_SHORTCUT);
+        i.putExtra(Intent.EXTRA_SHORTCUT_INTENT, shortcutIntent);
+        i.putExtra(Intent.EXTRA_SHORTCUT_NAME, title);
+        i.putExtra(Intent.EXTRA_SHORTCUT_ICON, icon);
+        return i;
+    }
+
+    public void addShortcutToHomeScreen(String title, Bitmap icon, Intent shortcutIntent) {

[gone, 2017/02/15 19:40:19]

public method -> add javadoc

[Marti Wong, 2017/02/17 05:10:49]

Done.

+        Intent intent = createAddToHomeIntent(title, icon, shortcutIntent);
+        ContextUtils.getApplicationContext().sendBroadcast(intent);
+    }
+
+    // TODO(crbug.com/635567): Fix this properly.
+    @SuppressLint("WrongConstant")
+    public boolean canAddShortcutToHomescreen() {
+        PackageManager pm = ContextUtils.getApplicationContext().getPackageManager();
+        Intent i = new Intent(INSTALL_SHORTCUT);
+        List<ResolveInfo> receivers =
+                pm.queryBroadcastReceivers(i, PackageManager.GET_INTENT_FILTERS);
+        return !receivers.isEmpty();
+    }
+
+    public boolean shouldShowToastWhenAddingShortcut() {
+        return true;
+    }
+}