Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Issue 2689993002: Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager (Closed)
Patch Set: Change according to review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.content.SharedPreferences; 10 import android.content.SharedPreferences;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 import org.chromium.chrome.browser.rlz.RevenueStats; 52 import org.chromium.chrome.browser.rlz.RevenueStats;
53 import org.chromium.chrome.browser.services.AndroidEduOwnerCheckCallback; 53 import org.chromium.chrome.browser.services.AndroidEduOwnerCheckCallback;
54 import org.chromium.chrome.browser.signin.GoogleActivityController; 54 import org.chromium.chrome.browser.signin.GoogleActivityController;
55 import org.chromium.chrome.browser.sync.GmsCoreSyncListener; 55 import org.chromium.chrome.browser.sync.GmsCoreSyncListener;
56 import org.chromium.chrome.browser.tab.AuthenticatorNavigationInterceptor; 56 import org.chromium.chrome.browser.tab.AuthenticatorNavigationInterceptor;
57 import org.chromium.chrome.browser.tab.Tab; 57 import org.chromium.chrome.browser.tab.Tab;
58 import org.chromium.chrome.browser.tabmodel.document.ActivityDelegateImpl; 58 import org.chromium.chrome.browser.tabmodel.document.ActivityDelegateImpl;
59 import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelSelector; 59 import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelSelector;
60 import org.chromium.chrome.browser.tabmodel.document.StorageDelegate; 60 import org.chromium.chrome.browser.tabmodel.document.StorageDelegate;
61 import org.chromium.chrome.browser.tabmodel.document.TabDelegate; 61 import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
62 import org.chromium.chrome.browser.webapps.ChromeShortcutManager;
62 import org.chromium.chrome.browser.webapps.GooglePlayWebApkInstallDelegate; 63 import org.chromium.chrome.browser.webapps.GooglePlayWebApkInstallDelegate;
63 import org.chromium.components.signin.AccountManagerDelegate; 64 import org.chromium.components.signin.AccountManagerDelegate;
64 import org.chromium.components.signin.SystemAccountManagerDelegate; 65 import org.chromium.components.signin.SystemAccountManagerDelegate;
65 import org.chromium.content.app.ContentApplication; 66 import org.chromium.content.app.ContentApplication;
66 import org.chromium.content.browser.ChildProcessCreationParams; 67 import org.chromium.content.browser.ChildProcessCreationParams;
67 import org.chromium.policy.AppRestrictionsProvider; 68 import org.chromium.policy.AppRestrictionsProvider;
68 import org.chromium.policy.CombinedPolicyProvider; 69 import org.chromium.policy.CombinedPolicyProvider;
69 70
70 /** 71 /**
71 * Basic application functionality that should be shared among all browser appli cations that use 72 * Basic application functionality that should be shared among all browser appli cations that use
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 */ 390 */
390 public AppDetailsDelegate createAppDetailsDelegate() { 391 public AppDetailsDelegate createAppDetailsDelegate() {
391 return null; 392 return null;
392 } 393 }
393 394
394 /** Returns the singleton instance of GooglePlayWebApkInstallDelegate. */ 395 /** Returns the singleton instance of GooglePlayWebApkInstallDelegate. */
395 public GooglePlayWebApkInstallDelegate getGooglePlayWebApkInstallDelegate() { 396 public GooglePlayWebApkInstallDelegate getGooglePlayWebApkInstallDelegate() {
396 return null; 397 return null;
397 } 398 }
398 399
400 /** Returns the singleton instance of ChromeShortcutManager */
401 public ChromeShortcutManager createChromeShortcutManager() {
402 return new ChromeShortcutManager();
403 }
404
399 /** 405 /**
400 * Returns the singleton instance of the DocumentTabModelSelector. 406 * Returns the singleton instance of the DocumentTabModelSelector.
401 * TODO(dfalcantara): Find a better place for this once we differentiate bet ween activity and 407 * TODO(dfalcantara): Find a better place for this once we differentiate bet ween activity and
402 * application-level TabModelSelectors. 408 * application-level TabModelSelectors.
403 * @return The DocumentTabModelSelector for the application. 409 * @return The DocumentTabModelSelector for the application.
404 */ 410 */
405 @SuppressFBWarnings("LI_LAZY_INIT_STATIC") 411 @SuppressFBWarnings("LI_LAZY_INIT_STATIC")
406 public static DocumentTabModelSelector getDocumentTabModelSelector() { 412 public static DocumentTabModelSelector getDocumentTabModelSelector() {
407 ThreadUtils.assertOnUiThread(); 413 ThreadUtils.assertOnUiThread();
408 if (sDocumentTabModelSelector == null) { 414 if (sDocumentTabModelSelector == null) {
(...skipping 13 matching lines...) Expand all
422 } 428 }
423 429
424 /** 430 /**
425 * Creates a new {@link AccountManagerDelegate}. 431 * Creates a new {@link AccountManagerDelegate}.
426 * @return the created {@link AccountManagerDelegate}. 432 * @return the created {@link AccountManagerDelegate}.
427 */ 433 */
428 public AccountManagerDelegate createAccountManagerDelegate() { 434 public AccountManagerDelegate createAccountManagerDelegate() {
429 return new SystemAccountManagerDelegate(this); 435 return new SystemAccountManagerDelegate(this);
430 } 436 }
431 } 437 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698