Refactor the INSTALL_SHORTCUT broadcast code into ChromeShortcutManager

chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
-import android.annotation.SuppressLint;
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.Intent;
 import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.content.pm.PackageManager.NameNotFoundException;
-import android.content.pm.ResolveInfo;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.graphics.Canvas;
 import android.graphics.Color;
 import android.graphics.Paint;
 import android.graphics.Rect;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.support.annotation.NonNull;
 import android.text.TextUtils;
 import android.util.Base64;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.blink_public.platform.WebDisplayMode;
 import org.chromium.chrome.R;
+import org.chromium.chrome.browser.webapps.ChromeShortcutManager;
 import org.chromium.chrome.browser.webapps.ChromeWebApkHost;
 import org.chromium.chrome.browser.webapps.WebApkInfo;
 import org.chromium.chrome.browser.webapps.WebappActivity;
 import org.chromium.chrome.browser.webapps.WebappAuthenticator;
 import org.chromium.chrome.browser.webapps.WebappDataStorage;
 import org.chromium.chrome.browser.webapps.WebappLauncherActivity;
 import org.chromium.chrome.browser.webapps.WebappRegistry;
 import org.chromium.chrome.browser.widget.RoundedIconGenerator;
 import org.chromium.content_public.common.ScreenOrientationConstants;
 import org.chromium.ui.widget.Toast;
@@ skipping 34 matching lines @@
     public static final String EXTRA_WEBAPK_PACKAGE_NAME =
             "org.chromium.chrome.browser.webapk_package_name";
 
     // When a new field is added to the intent, this version should be incremented so that it will
     // be correctly populated into the WebappRegistry/WebappDataStorage.
     public static final int WEBAPP_SHORTCUT_VERSION = 2;
 
     // This value is equal to kInvalidOrMissingColor in the C++ content::Manifest struct.
     public static final long MANIFEST_COLOR_INVALID_OR_MISSING = ((long) Integer.MAX_VALUE) + 1;
 
-    private static final String TAG = "ShortcutHelper";
-
     // There is no public string defining this intent so if Home changes the value, we
     // have to update this string.
-    private static final String INSTALL_SHORTCUT = "com.android.launcher.action.INSTALL_SHORTCUT";
+    public static final String INSTALL_SHORTCUT = "com.android.launcher.action.INSTALL_SHORTCUT";
+
+    private static final String TAG = "ShortcutHelper";

[dominickn, 2017/02/13 05:18:02]

You moved this TAG - perhaps put it back again?

[Marti Wong, 2017/02/14 02:42:47]

This TAG is moved to ChromeShortcutManager

 
     // The activity class used for launching a WebApk.
     private static final String WEBAPK_MAIN_ACTIVITY = "org.chromium.webapk.shell_apk.MainActivity";
 
     // These sizes are from the Material spec for icons:
     // https://www.google.com/design/spec/style/icons.html#icons-product-icons
     private static final float MAX_INNER_SIZE_RATIO = 1.25f;
     private static final float ICON_PADDING_RATIO = 2.0f / 44.0f;
     private static final float ICON_CORNER_RADIUS_RATIO = 1.0f / 16.0f;
     private static final float GENERATED_ICON_PADDING_RATIO = 1.0f / 12.0f;
     private static final float GENERATED_ICON_FONT_SIZE_RATIO = 1.0f / 3.0f;
 
     /** Broadcasts Intents out Android for adding the shortcut. */
     public static class Delegate {

[dominickn, 2017/02/13 05:18:02]

This isn't feasible right now (this comment is for the future!), but I think a
cleaner design might actually be to replace ShortcutHelper with
ChromeShortcutManager.

We can't do this right now, but when this all merges together we should consider
that. :)

[Marti Wong, 2017/02/14 02:42:47]

Thanks for the advice~!

         /**
          * Broadcasts an intent to all interested BroadcastReceivers.
          * @param context The Context to use.
          * @param intent The intent to broadcast.
          */
-        public void sendBroadcast(Context context, Intent intent) {
-            context.sendBroadcast(intent);
+        public void requestPinShortcut(final Context context, final Intent intent) {

[dominickn, 2017/02/13 05:18:02]

Perhaps call this method addShortcutToHomescreen?

[Marti Wong, 2017/02/14 02:42:47]

Done.

+            ChromeShortcutManager.getInstance(context).addShortcutToHomeScreen(context, intent);
         }
 
         /**
          * Returns the name of the fullscreen Activity to use when launching shortcuts.
          */
         public String getFullscreenAction() {
             return WebappLauncherActivity.ACTION_START_WEBAPP;
         }
     }
 
@@ skipping 31 matching lines @@
                         icon, WEBAPP_SHORTCUT_VERSION, displayMode, orientation, themeColor,
                         backgroundColor, iconUrl.isEmpty());
                 shortcutIntent.putExtra(EXTRA_MAC, getEncodedMac(context, url));
                 shortcutIntent.putExtra(EXTRA_SOURCE, source);
                 shortcutIntent.setPackage(context.getPackageName());
                 return shortcutIntent;
             }
             @Override
             protected void onPostExecute(final Intent resultIntent) {
                 Context context = ContextUtils.getApplicationContext();
-                sDelegate.sendBroadcast(
+                sDelegate.requestPinShortcut(
                         context, createAddToHomeIntent(userTitle, icon, resultIntent));
 
                 // Store the webapp data so that it is accessible without the intent. Once this
                 // process is complete, call back to native code to start the splash image
                 // download.
                 WebappRegistry.getInstance().register(
                         id, new WebappRegistry.FetchWebappDataStorageCallback() {
                             @Override
                             public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
                                 storage.updateFromShortcutIntent(resultIntent);
                                 nativeOnWebappDataStored(callbackPointer);
                             }
                         });
-
-                showAddedToHomescreenToast(userTitle);
+                if (ChromeShortcutManager.getInstance(context).canShowAddedToHomescreenToast(
+                            context)) {
+                    showAddedToHomescreenToast(userTitle);
+                }
             }
         }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
     }
 
     public static void addWebApkShortcut(Context context, String packageName) {
         PackageManager pm = context.getPackageManager();
         try {
             ApplicationInfo appInfo = pm.getApplicationInfo(
                     packageName, PackageManager.GET_META_DATA);
             String shortcutTitle = pm.getApplicationLabel(appInfo).toString();
             Bitmap shortcutIcon = ((BitmapDrawable) pm.getApplicationIcon(packageName)).getBitmap();
 
             Bitmap bitmap = createHomeScreenIconFromWebIcon(shortcutIcon);
             Intent i = new Intent();
             i.setClassName(packageName, WEBAPK_MAIN_ACTIVITY);
             i.addCategory(Intent.CATEGORY_LAUNCHER);
             context.sendBroadcast(createAddToHomeIntent(shortcutTitle, bitmap, i));

[pkotwicz, 2017/02/13 19:22:49]

Should we call requestPinShortcut() here too?

[Marti Wong, 2017/02/14 02:42:46]

Thanks for the comment!
Intent i has no id stored and it will cause a crash in requestPinShortcut() in
future update.
Actually, WebAPK people will be removing this part of code soon.
That's why we leave this one alone.

         } catch (NameNotFoundException e) {
             e.printStackTrace();
         }
     }
 
     /**
      * Adds home screen shortcut which opens in the browser Activity.
      */
     @SuppressWarnings("unused")
     @CalledByNative
-    private static void addShortcut(String url, String userTitle, Bitmap icon, int source) {
+    private static void addShortcut(
+            String id, String url, String userTitle, Bitmap icon, int source) {
         Context context = ContextUtils.getApplicationContext();
         final Intent shortcutIntent = createShortcutIntent(url);
+        shortcutIntent.putExtra(EXTRA_ID, id);
         shortcutIntent.putExtra(EXTRA_SOURCE, source);
         shortcutIntent.setPackage(context.getPackageName());
-        sDelegate.sendBroadcast(
+        sDelegate.requestPinShortcut(
                 context, createAddToHomeIntent(userTitle, icon, shortcutIntent));
-        showAddedToHomescreenToast(userTitle);
+        if (ChromeShortcutManager.getInstance(context).canShowAddedToHomescreenToast(context)) {
+            showAddedToHomescreenToast(userTitle);
+        }
     }
 
     /**
      * Show toast to alert user that the shortcut was added to the home screen.
      */
     private static void showAddedToHomescreenToast(final String title) {
         Context applicationContext = ContextUtils.getApplicationContext();
         String toastText = applicationContext.getString(R.string.added_to_homescreen, title);
         showToast(toastText);
     }
@@ skipping 124 matching lines @@
         Intent shortcutIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
         shortcutIntent.putExtra(REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);
         return shortcutIntent;
     }
 
     /**
      * Utility method to check if a shortcut can be added to the home screen.
      * @param context Context used to get the package manager.
      * @return if a shortcut can be added to the home screen under the current profile.
      */
-    // TODO(crbug.com/635567): Fix this properly.
-    @SuppressLint("WrongConstant")
     public static boolean isAddToHomeIntentSupported(Context context) {
-        PackageManager pm = context.getPackageManager();
-        Intent i = new Intent(INSTALL_SHORTCUT);
-        List<ResolveInfo> receivers = pm.queryBroadcastReceivers(
-                i, PackageManager.GET_INTENT_FILTERS);
-        return !receivers.isEmpty();
+        return ChromeShortcutManager.getInstance(context).isAddShortcutToHomeScreenSupported(
+                context);
     }
 
     /**
      * Returns whether the given icon matches the size requirements to be used on the home screen.
      * @param width Icon width, in pixels.
      * @param height Icon height, in pixels.
      * @return whether the given icon matches the size requirements to be used on the home screen.
      */
     @CalledByNative
     public static boolean isIconLargeEnoughForLauncher(int width, int height) {
@@ skipping 318 matching lines @@
         for (int i = 0; i < list.size(); i++) {
             array[i] = list.get(i);
         }
         return array;
     }
 
     private static native void nativeOnWebappDataStored(long callbackPointer);
     private static native void nativeOnWebApksRetrieved(long callbackPointer, String[] shortNames,
             String[] packageName, int[] shellApkVersions, int[] versionCodes);
 }