Reporting: Implement header parser.

net/reporting/reporting_header_parser_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/reporting/reporting_header_parser.h"
+
+#include <string>
+#include <vector>
+
+#include "base/memory/ptr_util.h"
+#include "base/test/simple_test_tick_clock.h"
+#include "base/time/time.h"
+#include "base/values.h"
+#include "net/reporting/reporting_cache.h"
+#include "net/reporting/reporting_client.h"
+#include "net/reporting/reporting_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+#include "url/origin.h"
+
+namespace net {
+namespace {
+
+const GURL kUrl("https://origin/path");
+const url::Origin kOrigin(GURL("https://origin/"));
+const GURL kEndpoint("https://endpoint/");
+const std::string kGroup("group");
+const std::string kType("type");

[jkarlin, 2017/03/28 18:29:50]

All of above need to be POD

[Julia Tuttle, 2017/03/28 20:28:55]

Moved into class instead.

+
+class ReportingHeaderParserTest : public ::testing::Test {
+ protected:
+  void ParseHeader(const GURL& url, const std::string& header_value) {
+    ReportingHeaderParser::ParseHeader(&cache_, clock_.NowTicks(), url,
+                                       header_value);
+  }
+  base::SimpleTestTickClock clock_;
+  ReportingCache cache_;
+};
+
+TEST_F(ReportingHeaderParserTest, Invalid) {
+  static const struct {
+    const char* header_value;
+    const char* description;
+  } kInvalidHeaderTestCases[] = {
+      {"{\"max-age\":1}", "missing url"},
+      {"{\"url\":0,\"max-age\":1}", "non-string url"},
+      {"{\"url\":\"http://insecure/\",\"max-age\":1}", "insecure url"},
+
+      {"{\"url\":\"https://endpoint/\"}", "missing max-age"},
+      {"{\"url\":\"https://endpoint/\",\"max-age\":\"\"}",
+       "non-integer max-age"},
+      {"{\"url\":\"https://endpoint/\",\"max-age\":-1}", "negative max-age"},
+
+      {"{\"url\":\"https://endpoint/\",\"max-age\":1,\"group\":0}",
+       "non-string group"},
+
+      // Note that a non-boolean includeSubdomains field is *not* invalid, per
+      // the spec.
+  };
+
+  for (size_t i = 0; i < arraysize(kInvalidHeaderTestCases); ++i) {
+    auto& test_case = kInvalidHeaderTestCases[i];
+    ParseHeader(kUrl, test_case.header_value);
+
+    std::vector<const ReportingClient*> clients;
+    cache_.GetClients(&clients);
+    EXPECT_TRUE(clients.empty())
+        << "Invalid Report-To header (" << test_case.description << ": \""
+        << test_case.header_value << "\") parsed as valid.";
+  }
+}
+
+TEST_F(ReportingHeaderParserTest, Valid) {
+  ParseHeader(kUrl, "{\"url\":\"" + kEndpoint.spec() + "\",\"max-age\":86400}");
+
+  const ReportingClient* client =
+      FindClientInCache(&cache_, kOrigin, kEndpoint);
+  ASSERT_TRUE(client);
+  EXPECT_EQ(kOrigin, client->origin);
+  EXPECT_EQ(kEndpoint, client->endpoint);
+  EXPECT_EQ(ReportingClient::Subdomains::EXCLUDE, client->subdomains);
+  EXPECT_EQ(86400, (client->expires - clock_.NowTicks()).InSeconds());
+}
+
+TEST_F(ReportingHeaderParserTest, Subdomains) {
+  ParseHeader(kUrl, "{\"url\":\"" + kEndpoint.spec() +
+                        "\",\"max-age\":86400,"
+                        "\"includeSubdomains\":true}");
+
+  const ReportingClient* client =
+      FindClientInCache(&cache_, kOrigin, kEndpoint);
+  ASSERT_TRUE(client);
+  EXPECT_EQ(ReportingClient::Subdomains::INCLUDE, client->subdomains);
+}
+
+TEST_F(ReportingHeaderParserTest, ZeroMaxAge) {
+  cache_.SetClient(kOrigin, kEndpoint, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup, clock_.NowTicks() + base::TimeDelta::FromDays(1));
+
+  ParseHeader(kUrl, "{\"url\":\"" + kEndpoint.spec() + "\",\"max-age\":0}");
+
+  EXPECT_FALSE(FindClientInCache(&cache_, kOrigin, kEndpoint) != nullptr);

[jkarlin, 2017/03/28 18:29:50]

EXPECT_EQ(nullptr, FindClientInCache(&cache_, kOrigin, kEndPoint))

[Julia Tuttle, 2017/03/28 20:28:55]

Done.

+}
+
+}  // namespace
+}  // namespace net