Reporting: Implement header parser.

net/reporting/reporting_delegate_impl.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_REPORTING_REPORTING_DELEGATE_IMPL_H_
+#define NET_REPORTING_REPORTING_DELEGATE_IMPL_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "base/time/tick_clock.h"
+#include "base/values.h"
+#include "net/base/net_export.h"
+#include "net/reporting/reporting_delegate.h"
+#include "url/gurl.h"
+
+namespace net {
+
+class ReportingCache;
+
+class NET_EXPORT ReportingDelegateImpl : public ReportingDelegate {
+ public:
+  ReportingDelegateImpl(base::TickClock* clock, ReportingCache* cache);

[shivanisha, 2017/03/15 23:38:01]

Since the constructor takes raw pointers, it needs documentation about the
lifetime of the passed pointers, whether |clock| and |cache| should outlive
|this| or not.

+
+  ~ReportingDelegateImpl() override;
+
+  void OnReportGenerated(const GURL& url,
+                         const std::string& group,
+                         const std::string& type,
+                         std::unique_ptr<const base::Value> body) override;
+
+  void OnHeaderReceived(const GURL& url,
+                        const std::string& json_value) override;
+
+ private:
+  // Processes a single endpoint's parsed value from the Report-To header(s).
+  // Creates, updates, or removes a client in the cache as needed.
+  //

[shivanisha, 2017/03/15 23:38:01]

We can probably remove the empty lines between parameter documentations. Had a
quick look at other header files and did not find them.

+  // |url| is the URL that the header came from.
+  //
+  // |value| is the parsed value.
+  void ProcessEndpoint(const GURL& url, const base::Value& value);
+
+  base::TickClock* clock_;
+  ReportingCache* cache_;
+
+  DISALLOW_COPY_AND_ASSIGN(ReportingDelegateImpl);
+};
+
+}  // namespace net
+
+#endif  // NET_REPORTING_REPORTING_DELEGATE_IMPL_H_