Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js

Issue 268993002: For non-editable content, selection editor commands are disabled Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js
diff --git a/LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js b/LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js
index b27deb810650072fa5c7545b9d8c7ad6b29135a4..d7f68075bd490da95275509293fbfa5e9189d6aa 100644
--- a/LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js
+++ b/LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js
@@ -73,6 +73,9 @@ function whenEnabled(command)
if (summaryInteger === 0x5E)
return "visible";
+ if (summaryInteger === 0x7E)
+ return "selectable, not necessarily editable";
+
return summaryInteger;
}
@@ -141,25 +144,25 @@ shouldBe("whenEnabled('Unscript')", "'richly editable'");
shouldBe("whenEnabled('Paste')", "'editable'");
shouldBe("whenEnabled('MoveBackwardAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveDownAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveDownAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveForwardAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveLeftAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveLeftAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveParagraphBackwardAndModifySelection')", "'visible'");
shouldBe("whenEnabled('MoveParagraphForwardAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveRightAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveRightAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveToBeginningOfDocumentAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveToBeginningOfLineAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveToBeginningOfLineAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveToBeginningOfParagraphAndModifySelection')", "'visible'");
shouldBe("whenEnabled('MoveToBeginningOfSentenceAndModifySelection')", "'visible'");
shouldBe("whenEnabled('MoveToEndOfDocumentAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveToEndOfLineAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveToEndOfLineAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveToEndOfParagraphAndModifySelection')", "'visible'");
shouldBe("whenEnabled('MoveToEndOfSentenceAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveUpAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveUpAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('MoveWordBackwardAndModifySelection')", "'visible'");
shouldBe("whenEnabled('MoveWordForwardAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveWordLeftAndModifySelection')", "'visible'");
-shouldBe("whenEnabled('MoveWordRightAndModifySelection')", "'visible'");
+shouldBe("whenEnabled('MoveWordLeftAndModifySelection')", "'selectable, not necessarily editable'");
+shouldBe("whenEnabled('MoveWordRightAndModifySelection')", "'selectable, not necessarily editable'");
shouldBe("whenEnabled('SelectLine')", "'visible'");
shouldBe("whenEnabled('SelectParagraph')", "'visible'");
shouldBe("whenEnabled('SelectSentence')", "'visible'");

Powered by Google App Engine
This is Rietveld 408576698