LayoutTests/editing/selection/place-caret-on-single-click-within-selected-readonly-text.html - Issue 268993002: For non-editable content, selection editor commands are disabled

Side by Side Diff: LayoutTests/editing/selection/place-caret-on-single-click-within-selected-readonly-text.html

Issue 268993002: For non-editable content, selection editor commands are disabled Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/editing/selection/place-caret-on-single-click-within-selected-readonly-text-expected.txt » ('j') | LayoutTests/editing/selection/select-by-char-and-word-in-readonly-texts-using-keys-with-caret-mode-off.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <p id="target">Some Text</p>

	4 <p>This tests caret placement when clicked once on existing selection in readonl y texts to allow further selection using keys.</p>
	Yuta Kitamura 2014/06/04 08:19:38 You can use description() function from js-test to You can use description() function from js-test to show the test description. b.rout 2014/06/04 12:53:04 Ok. Show quoted text On 2014/06/04 08:19:38, Yuta Kitamura wrote: > You can use description() function from js-test to show > the test description. Ok.
	5 <div id="console"></div>
	Yuta Kitamura 2014/06/04 08:19:38 js-test automatically creates the element for outp js-test automatically creates the element for output console, so you don't have to write your own one. b.rout 2014/06/04 12:53:04 Actually, I want the HTML content to come before t Show quoted text On 2014/06/04 08:19:38, Yuta Kitamura wrote: > js-test automatically creates the element for output console, > so you don't have to write your own one. Actually, I want the HTML content to come before the test results. Thats why I explicitly placed it.
	6 <script src="../../resources/js-test.js"></script>

	7 <script>

	8 if (window.testRunner) {
	Yuta Kitamura 2014/06/04 08:19:38 As a general rule, it is recommended to make the t As a general rule, it is recommended to make the test runnable on the normal browsers that do not expose test-only objects. If your test requires manual operations (like clicking in this test), it is encouraged to put the instructions of how to run the test manually, so people can run the test in their browsers. b.rout 2014/06/04 12:53:04 Ok. I will update the tests with instructions to m Show quoted text On 2014/06/04 08:19:38, Yuta Kitamura wrote: > As a general rule, it is recommended to make the test > runnable on the normal browsers that do not expose > test-only objects. > > If your test requires manual operations (like clicking > in this test), it is encouraged to put the instructions > of how to run the test manually, so people can run the > test in their browsers. Ok. I will update the tests with instructions to manually perform the test. But, I see some limitations in the eventSender simulator for keyboard and mouse events, which is why I couldn't write the actual test case I intended. For example, in this test case I wanted to write keyboard selection behavior. Even if I click in between the selection, caret position is always set to the end of the content. However, I could write tests to show the keyboard selection considering that position. But, the concern is it does set the position correctly.
	9 testRunner.overridePreference("WebKitEnableCaretBrowsing", false);

	10 testRunner.dumpAsText();

	11

	12 target = document.getElementById('target');

	13 target.focus();

	14

	15 eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop);

	16 eventSender.mouseDown();

	17 eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth, target.o ffsetTop);

	18 eventSender.mouseUp();

	19

	20 eventSender.mouseMoveTo(target.offsetLeft + (target.offsetWidth / 3), ta rget.offsetTop);

	21 eventSender.mouseDown();

	22 eventSender.mouseUp();

	23 shouldBeEqualToString("getSelection().type", "Caret");

	24 }

	25 </script>

	26 </body>

	27 </html>

OLD	NEW