Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2689903002: Add conversion routines from the plugin API to the server API (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add conversion routines from the plugin API to the server API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/92550811ac56c3bac44586dc96d324ec9d7d7f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/plugin/result_collector.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/plugin/result_converter.dart View 1 chunk +92 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/src/plugin/result_converter_test.dart View 1 chunk +436 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-11 22:27:06 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-11 22:38:21 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-12 16:19:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92550811ac56c3bac44586dc96d324ec9d7d7f21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698