media/blink/webmediaplayer_impl.h - Issue 2689863002: Change ownership of PipelineImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2689863002: Change ownership of PipelineImpl (Closed)

Patch Set: Remove leftover test method Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 974141cb1d9d30f3779f8b24b7384528e2624401..8ce8140619b41bc2da90edeb9c65098b1d0ed2ac 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -477,9 +477,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

scoped_refptr<base::TaskRunner> worker_task_runner_;

scoped_refptr<MediaLog> media_log_;

- // |pipeline_controller_| references |pipeline_| and therefore must be

- // constructed after and destructed before |pipeline_|.

- PipelineImpl pipeline_;

+ // |pipeline_controller_| owns an instance of Pipeline.

PipelineController pipeline_controller_;

// The LoadType passed in the |load_type| parameter of the load() call.

« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | media/filters/pipeline_controller.h » ('J')