Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: media/blink/webmediaplayer_impl.h

Issue 2689863002: Change ownership of PipelineImpl (Closed)
Patch Set: Remove leftover test method Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | media/filters/pipeline_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 MultibufferDataSource::BufferingStrategy buffering_strategy_; 470 MultibufferDataSource::BufferingStrategy buffering_strategy_;
471 471
472 // Task runner for posting tasks on Chrome's main thread. Also used 472 // Task runner for posting tasks on Chrome's main thread. Also used
473 // for DCHECKs so methods calls won't execute in the wrong thread. 473 // for DCHECKs so methods calls won't execute in the wrong thread.
474 const scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_; 474 const scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
475 475
476 scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_; 476 scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
477 scoped_refptr<base::TaskRunner> worker_task_runner_; 477 scoped_refptr<base::TaskRunner> worker_task_runner_;
478 scoped_refptr<MediaLog> media_log_; 478 scoped_refptr<MediaLog> media_log_;
479 479
480 // |pipeline_controller_| references |pipeline_| and therefore must be 480 // |pipeline_controller_| owns an instance of Pipeline.
481 // constructed after and destructed before |pipeline_|.
482 PipelineImpl pipeline_;
483 PipelineController pipeline_controller_; 481 PipelineController pipeline_controller_;
484 482
485 // The LoadType passed in the |load_type| parameter of the load() call. 483 // The LoadType passed in the |load_type| parameter of the load() call.
486 LoadType load_type_; 484 LoadType load_type_;
487 485
488 // Cache of metadata for answering hasAudio(), hasVideo(), and naturalSize(). 486 // Cache of metadata for answering hasAudio(), hasVideo(), and naturalSize().
489 PipelineMetadata pipeline_metadata_; 487 PipelineMetadata pipeline_metadata_;
490 488
491 // Whether the video is known to be opaque or not. 489 // Whether the video is known to be opaque or not.
492 bool opaque_; 490 bool opaque_;
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 700
703 // Pipeline media duration overridden by tests. 701 // Pipeline media duration overridden by tests.
704 base::Optional<base::TimeDelta> pipeline_media_duration_for_test_; 702 base::Optional<base::TimeDelta> pipeline_media_duration_for_test_;
705 703
706 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 704 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
707 }; 705 };
708 706
709 } // namespace media 707 } // namespace media
710 708
711 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 709 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | media/filters/pipeline_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698