Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Issue 2689833002: DevTools: Server Timing values should be in milliseconds (Closed)
Patch Set: nullable value. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sdk/ServerTiming.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
index 9c7a27733854dd4a36ae3e837357bf695995deeb..2ef51d77901b02ef94efa89109e02c972ae0bd40 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
@@ -273,8 +273,11 @@ Network.RequestTimingView = class extends UI.VBox {
var metric = tr.createChild('td', 'network-timing-metric');
metric.createTextChild(serverTiming.description || serverTiming.metric);
var row = tr.createChild('td').createChild('div', 'network-timing-row');
- var left = scale * (endTime - startTime - serverTiming.value);
- if (serverTiming.value && left >= 0) { // don't chart values too big or too small
+
+ if (serverTiming.value === null)
+ return;
+ var left = scale * (endTime - startTime - (serverTiming.value / 1000));
+ if (left >= 0) { // don't chart values too big or too small
var bar = row.createChild('span', 'network-timing-bar server-timing');
bar.style.left = left + '%';
bar.style.right = right + '%';
@@ -283,8 +286,7 @@ Network.RequestTimingView = class extends UI.VBox {
bar.style.backgroundColor = colorGenerator.colorForID(serverTiming.metric);
}
var label = tr.createChild('td').createChild('div', 'network-timing-bar-title');
- if (typeof serverTiming.value === 'number') // a metric timing value is optional
- label.textContent = Number.secondsToString(serverTiming.value, true);
+ label.textContent = Number.millisToString(serverTiming.value, true);
}
/**
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sdk/ServerTiming.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698