DevTools: Server Timing values should be in milliseconds

third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
index 9c7a27733854dd4a36ae3e837357bf695995deeb..86ceec1cb012d5ce85ff89480fa4d61c0a0e122b 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
@@ -273,8 +273,11 @@ Network.RequestTimingView = class extends UI.VBox {
       var metric = tr.createChild('td', 'network-timing-metric');
       metric.createTextChild(serverTiming.description || serverTiming.metric);
       var row = tr.createChild('td').createChild('div', 'network-timing-row');
-      var left = scale * (endTime - startTime - serverTiming.value);
-      if (serverTiming.value && left >= 0) {  // don't chart values too big or too small
+
+      if (typeof serverTiming.value !== 'number')

[allada, 2017/02/14 00:00:24]

Can we do this instead?

if (serverTiming.value === null)

[paulirish, 2017/02/14 01:25:06]

yup

+        return;
+      var left = scale * (endTime - startTime - (serverTiming.value / 1000));
+      if (left >= 0) {  // don't chart values too big or too small
         var bar = row.createChild('span', 'network-timing-bar server-timing');
         bar.style.left = left + '%';
         bar.style.right = right + '%';
@@ -283,8 +286,7 @@ Network.RequestTimingView = class extends UI.VBox {
           bar.style.backgroundColor = colorGenerator.colorForID(serverTiming.metric);
       }
       var label = tr.createChild('td').createChild('div', 'network-timing-bar-title');
-      if (typeof serverTiming.value === 'number')  // a metric timing value is optional
-        label.textContent = Number.secondsToString(serverTiming.value, true);
+      label.textContent = Number.millisToString(serverTiming.value, true);
     }
 
     /**